Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: install "ipywidgets" warning #1120

Open
sylvaincom opened this issue Jan 15, 2025 · 1 comment
Open

docs: install "ipywidgets" warning #1120

sylvaincom opened this issue Jan 15, 2025 · 1 comment
Labels
invalid This doesn't seem right

Comments

@sylvaincom
Copy link
Contributor

sylvaincom commented Jan 15, 2025

Problem

When running:

from sklearn.datasets import load_breast_cancer
from sklearn.linear_model import LogisticRegression
from sklearn.model_selection import train_test_split
from skore import EstimatorReport
X_train, X_test, y_train, y_test = train_test_split(
    *load_breast_cancer(return_X_y=True), random_state=0
)
classifier = LogisticRegression(max_iter=10_000)
reporter = EstimatorReport(
    classifier,
    X_train=X_train,
    y_train=y_train,
    X_test=X_test,
    y_test=y_test,
)
reporter.cache_predictions()
reporter._cache

I got the following warning

/Users/sylvaincom/Documents/GitHub/skore/.venv/lib/python3.12/site-packages/rich/live.py:231: UserWarning: install 
"ipywidgets" for Jupyter support
  warnings.warn('install "ipywidgets" for Jupyter support')

Solution

Should we add something to the pyproject.toml as we use rich "everywhere"?

@sylvaincom sylvaincom added documentation Improvements or additions to documentation needs-triage This has been recently submitted and needs attention invalid This doesn't seem right and removed documentation Improvements or additions to documentation needs-triage This has been recently submitted and needs attention labels Jan 15, 2025
@glemaitre
Copy link
Member

True that I added ipywidget as a dependency in my project. Here, we could consider it a soft dependencies maybe. I don't know if @rouk1 was planning to have it as a hard dependency at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants