Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should bullet proof the find_ml_task in EstimatorReport #1092

Closed
glemaitre opened this issue Jan 10, 2025 · 1 comment · Fixed by #1136
Closed

We should bullet proof the find_ml_task in EstimatorReport #1092

glemaitre opened this issue Jan 10, 2025 · 1 comment · Fixed by #1136

Comments

@glemaitre
Copy link
Member

It is not an actual bug but reading again this line:

self._ml_task = _find_ml_task(self._y_test, estimator=self._estimator)

in the initialization stage makes me think that we should double check that we are fine (and maybe more tests). Basically, since we allow y_test to be None sometimes, I want just to be sure that estimator is not in a stage where everything is unifitted and None.

From the top of the head, we should be fine because we should a fitted estimator when y_test is None but we should double check.

@augustebaum
Copy link
Contributor

Related to #1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants