Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in CrossValidationReporter plots neg_RMSE is not negative #1010

Closed
MarieS-WiMLDS opened this issue Dec 23, 2024 · 1 comment · Fixed by #1009
Closed

in CrossValidationReporter plots neg_RMSE is not negative #1010

MarieS-WiMLDS opened this issue Dec 23, 2024 · 1 comment · Fixed by #1009
Labels
bug Something isn't working

Comments

@MarieS-WiMLDS
Copy link
Contributor

Describe the bug

Capture d’écran du 2024-12-23 15-50-21

Steps/Code to Reproduce

import skore 
project = skore.create("my_project", overwrite = True)
from sklearn.datasets import make_regression
X, y = make_regression(n_samples=500, n_features=7, noise=1, random_state=1)
from sklearn.ensemble import HistGradientBoostingRegressor
reg = HistGradientBoostingRegressor()
cv_reporter_reg = skore.CrossValidationReporter(reg, X, y, cv=10)
project.put("cv_regression", cv_reporter_reg)

Expected Behavior

if the value if positive, the name shouldn't start with neg.

Actual Behavior

Neg.

Environment

System:
    python: 3.12.8 | packaged by Anaconda, Inc. | (main, Dec 11 2024, 16:31:09) [GCC 11.2.0]
executable: /home/marie/anaconda3/envs/skore_test/bin/python
   machine: Linux-6.8.0-49-generic-x86_64-with-glibc2.35

Python dependencies:
        skore: 0.0.0+unknown
          pip: 24.2
   setuptools: 75.1.0
    diskcache: 5.6.3
      fastapi: 0.115.6
        numpy: 2.2.0
 plotly<6,>=5: None
      pyarrow: 18.1.0
         rich: 13.9.4
scikit-learn<1.7: None
        skops: 0.11.0
      uvicorn: 0.32.1
@MarieS-WiMLDS MarieS-WiMLDS added the bug Something isn't working label Dec 23, 2024
@glemaitre
Copy link
Member

It should be fixed in #1009 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants