From b85b79739ce02bdbeb5455a2f4e902e79c052dcf Mon Sep 17 00:00:00 2001 From: "Matt J." Date: Mon, 3 Feb 2025 12:37:27 +0100 Subject: [PATCH] chore(UI): Remove view builder (#1267) Closes #1266. This PR removes all view builder related code. Activity feed item now have a version number in backend aswell as in frontend. User can now annotate there items in the activity feed. ## UI preview: https://github.com/user-attachments/assets/7f283b74-17a4-4f4b-a6cc-a043a2415b24 --- skore-ui/src/SkoreUi.vue | 29 +- skore-ui/src/StandaloneWidget.vue | 1 + skore-ui/src/assets/styles/_typography.css | 1 - skore-ui/src/components/FloatingTooltip.vue | 2 +- skore-ui/src/components/RichTextEditor.vue | 5 +- skore-ui/src/dto.ts | 22 +- skore-ui/src/models.ts | 2 + skore-ui/src/router.ts | 10 - skore-ui/src/services/api.ts | 54 +-- skore-ui/src/stores/project.ts | 438 ------------------ skore-ui/src/views/AppToolbar.vue | 49 +- .../views/activity/ActivityFeedCardHeader.vue | 26 +- .../src/views/activity/ActivityFeedItem.vue | 68 +++ .../src/views/activity/ActivityFeedView.vue | 59 +-- .../src/views/activity/ItemNoteEditor.vue | 121 +++++ skore-ui/src/views/activity/activity.ts | 83 ++++ skore-ui/src/views/project/ItemNote.vue | 162 ------- .../src/views/project/ProjectItemList.vue | 97 ---- skore-ui/src/views/project/ProjectView.vue | 246 ---------- .../views/project/ProjectViewNavigator.vue | 229 --------- skore-ui/tests/services/api.spec.ts | 18 +- skore-ui/tests/stores/project.spec.ts | 112 ----- skore-ui/tests/views/ProjectView.spec.ts | 49 -- .../tests/views/ProjectViewNavigator.spec.ts | 94 ---- skore-ui/tests/views/activity.spec.ts | 59 +++ .../skore/persistence/repository/__init__.py | 2 - .../persistence/repository/view_repository.py | 87 ---- skore/src/skore/project/project.py | 16 +- skore/src/skore/ui/project_routes.py | 91 +--- skore/tests/conftest.py | 4 +- skore/tests/integration/ui/test_ui.py | 343 ++++++-------- skore/tests/unit/project/test_project.py | 2 - skore/tests/unit/utils/test_environment.py | 6 + skore/tests/unit/view/test_view_repository.py | 36 -- 34 files changed, 626 insertions(+), 1997 deletions(-) delete mode 100644 skore-ui/src/stores/project.ts create mode 100644 skore-ui/src/views/activity/ActivityFeedItem.vue create mode 100644 skore-ui/src/views/activity/ItemNoteEditor.vue create mode 100644 skore-ui/src/views/activity/activity.ts delete mode 100644 skore-ui/src/views/project/ItemNote.vue delete mode 100644 skore-ui/src/views/project/ProjectItemList.vue delete mode 100644 skore-ui/src/views/project/ProjectView.vue delete mode 100644 skore-ui/src/views/project/ProjectViewNavigator.vue delete mode 100644 skore-ui/tests/stores/project.spec.ts delete mode 100644 skore-ui/tests/views/ProjectView.spec.ts delete mode 100644 skore-ui/tests/views/ProjectViewNavigator.spec.ts create mode 100644 skore-ui/tests/views/activity.spec.ts delete mode 100644 skore/src/skore/persistence/repository/view_repository.py delete mode 100644 skore/tests/unit/view/test_view_repository.py diff --git a/skore-ui/src/SkoreUi.vue b/skore-ui/src/SkoreUi.vue index 2eec868f4..b05ad02ca 100644 --- a/skore-ui/src/SkoreUi.vue +++ b/skore-ui/src/SkoreUi.vue @@ -17,13 +17,15 @@ const themesStore = useThemesStore();
- +