Use commitments from config, fixes to issue and redeem for no-reload #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxdavids
reviewed
Oct 24, 2019
There was a problem hiding this comment.
Thanks!
Just a small fix required. Would it be possible to say exactly why the xhrInfo.cancel flag is required? Maybe a comment would be useful here.
Also, if there are any tests that you could add to make sure your workflow is working correctly then this will make future development easier for us, in case we make changes that may affect your workflow.
|
@alxdavids thank you for the quick turnaround, fixed that silly definition error, also added a brief description of the issue workflow. I'd be happy to hop on a call and go over it in more detail :) |
alxdavids
approved these changes
Oct 24, 2019
armfazh
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alxdavids Resubmitting our latest compatibility fixes, as per your suggestion we're using commitments from
config.js, also fixing some issues we've found with theno-reloadmethod.Feedback is very welcome!