fix: do not compile with slither but with yarn

privacy-scaling-explorations · Jun 24, 2024 · 5900c42 · 5900c42
1 parent 9fb9af3
commit 5900c42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -89,13 +89,20 @@ jobs:
                 dir: ${{ fromJson(needs.set-slither-matrix.outputs.matrix) }}
         steps:
             - uses: actions/checkout@v4
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: "20"
+                  cache: yarn
+            - run: yarn
+            - run: yarn compile
+
             - name: Run slither
               uses: crytic/slither-action@v0.4.0
               id: slither
               with:
                   sarif: results.sarif
                   fail-on: none
-                  slither-args: --filter-paths "test" --exclude-dependencies --markdown-root ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }}/
+                  slither-args: --ignore-compile --filter-paths "test" --exclude-dependencies --markdown-root ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }}/
                   target: packages/${{ matrix.dir }}
             - name: Upload SARIF files
               uses: github/codeql-action/upload-sarif@v3

diff --git a/package.json b/package.json
@@ -7,8 +7,8 @@
     "bugs": "https://github.com/privacy-scaling-explorations/zk-kit.solidity/issues",
     "private": true,
     "scripts": {
-        "compile": "yarn workspaces foreach -A run compile",
-        "test": "yarn workspaces foreach -A run test:coverage",
+        "compile": "yarn workspaces foreach -Ap run compile",
+        "test": "yarn workspaces foreach -Ap run test:coverage",
         "version:bump": "yarn workspace @zk-kit/${0}.sol version ${1} && yarn remove:stable-version-field ${0} && NO_HOOK=1 git commit -am \"chore(${0}): v${1}\" && git tag ${0}.sol-v${1}",
         "version:publish": "yarn workspaces foreach -A --no-private npm publish --tolerate-republish --access public",
         "version:release": "changelogithub",