Specific migrations are not handled correctly

[marktani]

Two different cases. Version: 1.0.0-beta.4.1.4

First

First, deploy

type User {
  instagram: String
}

Then deploy

type Instagram {
  name: String!
}

type User {
  instagram: Instagram!
}

Deploying is stuck forever:

Changes:

  Instagram (Type)
  + Created type `Instagram`
  + Created field `name` of type `String!`
  + Created field `id` of type `GraphQLID!`
  + Created field `updatedAt` of type `DateTime!`
  + Created field `createdAt` of type `DateTime!`

  User (Type)
  ~ Updated field `instagram`. It became required.

  InstagramToUser (Relation)
  + Created relation between Instagram and User

Applying changes (5/7) ⣾

Second

First, deploy

type User {
  instagram: String
}

Then, deploy

type InstagramMedia {
  type: String!
  mediaUrl: String!
  thumbnailUrl: String
  permalink: String!
  likeCount: Int!
  timestamp: DateTime!
}

type User {
  instagram: Instagram!
}

type Instagram {
  name: String!
}

Error result:

Changes:

  InstagramMedia (Type)
  + Created type `InstagramMedia`
  + Created field `type` of type `String!`
  + Created field `mediaUrl` of type `String!`
  + Created field `thumbnailUrl` of type `String`
  + Created field `permalink` of type `String!`
  + Created field `likeCount` of type `Int!`
  + Created field `timestamp` of type `DateTime!`
  + Created field `id` of type `GraphQLID!`
  + Created field `updatedAt` of type `DateTime!`
  + Created field `createdAt` of type `DateTime!`

  Instagram (Type)
  + Created type `Instagram`
  + Created field `name` of type `String!`
  + Created field `id` of type `GraphQLID!`
  + Created field `updatedAt` of type `DateTime!`
  + Created field `createdAt` of type `DateTime!`

  User (Type)
  ~ Updated field `instagram`. It became required.

  InstagramToUser (Relation)
  + Created relation between Instagram and User

Applying changes !
 ▸    java.lang.RuntimeException: Relation is not a scalar type. Are you trying
 ▸    to create a db column for a relation?
 ▸    at scala.sys.package$.error(package.scala:27)
 ▸    at
 ▸    cool.graph.deploy.database.DatabaseMutationBuilder$.sqlTypeForScalarTypeIdentifier(DatabaseMutationBuilder.scala:182)
 ▸    at
 ▸    cool.graph.deploy.database.DatabaseMutationBuilder$.updateColumn(DatabaseMutationBuilder.scala:129)
 ▸    at
 ▸    cool.graph.deploy.migration.mutactions.UpdateColumn.updateFromBeforeStateToAfterState(UpdateColumn.scala:56)
 ▸    at
 ▸    cool.graph.deploy.migration.mutactions.UpdateColumn.execute(UpdateColumn.scala:17)
 ▸    at
 ▸    cool.graph.deploy.migration.migrator.MigrationApplierImpl.executeClientMutaction(MigrationApplier.scala:108)
 ▸    at
 ▸    cool.graph.deploy.migration.migrator.MigrationApplierImpl.applyStep(MigrationApplier.scala:94)
 ▸    at
 ▸    cool.graph.deploy.migration.migrator.MigrationApplierImpl.recurseForward(MigrationApplier.scala:45)
 ▸    at
 ▸    cool.graph.deploy.migration.migrator.MigrationApplierImpl.$anonfun$recurseForward$3(MigrationApplier.scala:48)
 ▸    at scala.concurrent.Future.$anonfun$flatMap$1(Future.scala:302)
 ▸    at
 ▸    scala.concurrent.impl.Promise.$anonfun$transformWith$1(Promise.scala:37)
 ▸    at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60)
 ▸    at
 ▸    akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55)
 ▸    at
 ▸    akka.dispatch.BatchingExecutor$BlockableBatch.$anonfun$run$1(BatchingExecutor.scala:91)
 ▸    at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
 ▸    at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:81)
 ▸    at
 ▸    akka.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:91)
 ▸    at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
 ▸    at
 ▸    akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:43)
 ▸    at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
 ▸    at
 ▸    akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
 ▸    at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
 ▸    at
 ▸    akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
 ▸

Get in touch if you need help: https://www.graph.cool/forum
To get more detailed output, run $ set -x DEBUG "*"

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.