Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dripip github action #57

Open
jasonkuhrt opened this issue Apr 2, 2020 · 3 comments
Open

dripip github action #57

jasonkuhrt opened this issue Apr 2, 2020 · 3 comments
Labels
impact/high type/feat Add a new capability or enhance an existing one

Comments

@jasonkuhrt
Copy link
Member

https://help.github.com/en/actions/building-actions/creating-a-javascript-action

Instead of this:

      - name: Make release
        id: release
        env:
          NPM_TOKEN: ${{secrets.NPM_TOKEN}}
        run: |
          yarn -s dripip preview --json > result.json
          result=$(cat result.json)
          echo '==> Publish Result'
          jq '.' <<< $result
      - name: Save publish result
        uses: actions/upload-artifact@v1
        with:
          name: published
          path: result.json

This

- uses: prisma-labs/dripip
  with:
    npm_token: ${{ secrets.NPM_TOKEN }}    

For handling the artifacts part, refer to this issue which mentions more actions/upload-artifact#62.

@jasonkuhrt jasonkuhrt added type/feat Add a new capability or enhance an existing one impact/high labels Apr 2, 2020
@jasonkuhrt jasonkuhrt mentioned this issue Apr 2, 2020
@jasonkuhrt
Copy link
Member Author

In lieu of #58 we might be able to workaround using forks. If we really want to avoid the sdk work for now.

@jasonkuhrt
Copy link
Member Author

  1. New requirement discovered for this issue from Handling GITHUB_TOKEN now with changelog support #71. CI now needs GITHUB_TOKEN.

  2. Another thing we need to cover, hit this today (don't know why I didn't hit it before...) RFC: fetch-depth: 1 and not cloning tags are dangerous defaults actions/checkout#217; specifically the part about needing to pull in all git tags (depth: 0 I knew about from before).

@jasonkuhrt
Copy link
Member Author

jasonkuhrt commented Apr 22, 2020

Note the solution for pulling git tags has some discussion here actions/checkout#206 / actions/checkout#206 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/high type/feat Add a new capability or enhance an existing one
Projects
None yet
Development

No branches or pull requests

1 participant