Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: include pngquant and jpegoptim #6

Open
dohomi opened this issue Jun 20, 2017 · 3 comments
Open

feature request: include pngquant and jpegoptim #6

dohomi opened this issue Jun 20, 2017 · 3 comments

Comments

@dohomi
Copy link

dohomi commented Jun 20, 2017

Hi

it would be great if this lambda function would also provide image optimization via pngquant and jpegoptim.

Mabe its possible to use similar approach like this package: https://github.com/ysugimoto/aws-lambda-image

Thanks

@schickling
Copy link
Contributor

Please feel free to create a PR which enables multiple image engines. :shipit:

@dohomi
Copy link
Author

dohomi commented Jun 20, 2017

@schickling one question: what happens under the hood if the processing is finished? Is the image persisted with a new path on S3 internally? Are the S3 sources delivered through a CDN?

To contribute to this package I would ne a guidance how to setup the project locally. Haven't used serverless for long time.

@schickling
Copy link
Contributor

At the moment, the images are just kept in memory and are returned as a base64 encoded string which API Gateway returns as a binary resource.

You can setup the project locally like described here. Unfortunately serverless-offline doesn't support binary return types yet, so you cannot easily test it locally at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants