diff --git a/Gemfile b/Gemfile index 13a3ca0883..9883e0e6e0 100644 --- a/Gemfile +++ b/Gemfile @@ -61,7 +61,7 @@ group :development do gem "capybara", "~> 3.39.2" gem "cuprite", "~> 0.14.3" gem "erb_lint", "~> 0.4.0" - gem "erblint-github", "~> 0.4.1" + gem "erblint-github", "~> 0.5.1" gem "listen", "~> 3.0" gem "matrix", "~> 0.4.2" gem "mocha" diff --git a/Gemfile.lock b/Gemfile.lock index c8b63b9045..c5a0b35c8f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -86,7 +86,7 @@ GEM rainbow rubocop smart_properties - erblint-github (0.4.1) + erblint-github (0.5.1) erubi (1.12.0) ferrum (0.13) addressable (~> 2.5) @@ -288,7 +288,7 @@ DEPENDENCIES capybara (~> 3.39.2) cuprite (~> 0.14.3) erb_lint (~> 0.4.0) - erblint-github (~> 0.4.1) + erblint-github (~> 0.5.1) kramdown (~> 2.4) listen (~> 3.0) lookbook (~> 2.1.1) diff --git a/demo/app/views/action_menu/deferred.html.erb b/demo/app/views/action_menu/deferred.html.erb index 7e4793c923..59e1129010 100644 --- a/demo/app/views/action_menu/deferred.html.erb +++ b/demo/app/views/action_menu/deferred.html.erb @@ -11,7 +11,6 @@ ) %> <% end %> - <%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: "Confirm deletion")) do |d| %> <%= render(Primer::Alpha::Dialog::Body.new()) do %> Are you sure you want to delete this? diff --git a/demo/app/views/action_menu/form_action.html.erb b/demo/app/views/action_menu/form_action.html.erb index 4004815c8b..9aac103c6b 100644 --- a/demo/app/views/action_menu/form_action.html.erb +++ b/demo/app/views/action_menu/form_action.html.erb @@ -1,2 +1,2 @@ -You selected <%= @value.inspect %>
+You selected <%= @value.inspect %>
Other params sent to server: <%= @other_params.inspect %> diff --git a/demo/app/views/auto_complete_test/index.html.erb b/demo/app/views/auto_complete_test/index.html.erb index 47f495278a..e73b152eb5 100644 --- a/demo/app/views/auto_complete_test/index.html.erb +++ b/demo/app/views/auto_complete_test/index.html.erb @@ -1,3 +1,4 @@ +<%# erblint:counter DeprecatedComponentsCounter 2 %> <% @fruit_list.each do |fruit| %> <% if params['version'] == "alpha" %> <%= render(Primer::Alpha::AutoComplete::Item.new(value: fruit)) { fruit } %> diff --git a/demo/app/views/layouts/component_preview.html.erb b/demo/app/views/layouts/component_preview.html.erb index 1848dbf824..4af00a0445 100644 --- a/demo/app/views/layouts/component_preview.html.erb +++ b/demo/app/views/layouts/component_preview.html.erb @@ -18,7 +18,7 @@
- <% if params.dig(:lookbook, :display, :theme) == "all" || params.dig(:theme) == "all" %> + <% if params.dig(:lookbook, :display, :theme) == "all" || params.dig(:theme) == "all" %>
<% color_themes.each do |theme| %>
> diff --git a/demo/app/views/layouts/mailer.html.erb b/demo/app/views/layouts/mailer.html.erb index cbd34d2e9d..3aac9002ed 100644 --- a/demo/app/views/layouts/mailer.html.erb +++ b/demo/app/views/layouts/mailer.html.erb @@ -1,7 +1,7 @@ - + diff --git a/script/erblint b/script/erblint new file mode 100755 index 0000000000..f7e7581247 --- /dev/null +++ b/script/erblint @@ -0,0 +1,8 @@ +#! /bin/bash + +bundle exec erblint \ + app/**/*.html.erb \ + lib/**/*.html.erb \ + demo/app/**/*.html.erb \ + test/**/*.html.erb \ + ${@}