From 5a0de70c60c217b3d1ffd1c594398ab470651076 Mon Sep 17 00:00:00 2001 From: Cameron Dutro Date: Wed, 2 Aug 2023 11:39:29 -0700 Subject: [PATCH 1/2] Allow disabling submit buttons --- lib/primer/forms/button.rb | 4 ---- test/lib/primer/forms_test.rb | 7 ------- 2 files changed, 11 deletions(-) diff --git a/lib/primer/forms/button.rb b/lib/primer/forms/button.rb index da49d90552..b456420a3b 100644 --- a/lib/primer/forms/button.rb +++ b/lib/primer/forms/button.rb @@ -39,10 +39,6 @@ def initialize(input:, type: :button) # rails uses a string for this, but PVC wants a symbol @input.merge_input_arguments!(type: type.to_sym) - - # Never allow buttons to be disabled. Disabling buttons is not accessible. - # See: https://primer.style/design/ui-patterns/saving#state - @input.input_arguments.delete(:disabled) end def input_arguments diff --git a/test/lib/primer/forms_test.rb b/test/lib/primer/forms_test.rb index f3325a6e44..b8e62327b2 100644 --- a/test/lib/primer/forms_test.rb +++ b/test/lib/primer/forms_test.rb @@ -132,13 +132,6 @@ def test_renders_buttons_with_slots end end - def test_disallows_disabled_buttons - render_preview :submit_button_form - - button = page.find_all("button[type=submit]").first - assert_nil button["disabled"] - end - def test_renders_buttons_with_primer_utility_margins render_preview :submit_button_form From a3b7c1fe1ab5c619afd394c7b05ee763a9f7a819 Mon Sep 17 00:00:00 2001 From: Cameron Dutro Date: Wed, 2 Aug 2023 11:40:02 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/eighty-carrots-protect.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/eighty-carrots-protect.md diff --git a/.changeset/eighty-carrots-protect.md b/.changeset/eighty-carrots-protect.md new file mode 100644 index 0000000000..94ff1aa1a7 --- /dev/null +++ b/.changeset/eighty-carrots-protect.md @@ -0,0 +1,7 @@ +--- +'@primer/view-components': minor +--- + +Allow disabling submit buttons + +