diff --git a/.changeset/eighty-carrots-protect.md b/.changeset/eighty-carrots-protect.md new file mode 100644 index 0000000000..94ff1aa1a7 --- /dev/null +++ b/.changeset/eighty-carrots-protect.md @@ -0,0 +1,7 @@ +--- +'@primer/view-components': minor +--- + +Allow disabling submit buttons + + diff --git a/lib/primer/forms/button.rb b/lib/primer/forms/button.rb index da49d90552..b456420a3b 100644 --- a/lib/primer/forms/button.rb +++ b/lib/primer/forms/button.rb @@ -39,10 +39,6 @@ def initialize(input:, type: :button) # rails uses a string for this, but PVC wants a symbol @input.merge_input_arguments!(type: type.to_sym) - - # Never allow buttons to be disabled. Disabling buttons is not accessible. - # See: https://primer.style/design/ui-patterns/saving#state - @input.input_arguments.delete(:disabled) end def input_arguments diff --git a/test/lib/primer/forms_test.rb b/test/lib/primer/forms_test.rb index f3325a6e44..b8e62327b2 100644 --- a/test/lib/primer/forms_test.rb +++ b/test/lib/primer/forms_test.rb @@ -132,13 +132,6 @@ def test_renders_buttons_with_slots end end - def test_disallows_disabled_buttons - render_preview :submit_button_form - - button = page.find_all("button[type=submit]").first - assert_nil button["disabled"] - end - def test_renders_buttons_with_primer_utility_margins render_preview :submit_button_form