From a42d20c0d76803c0f43d8b7901ff2a587d4a7284 Mon Sep 17 00:00:00 2001 From: Cameron Dutro Date: Tue, 7 Mar 2023 15:28:18 -0800 Subject: [PATCH 1/2] Deny tag argument for ActionList headings --- app/components/primer/alpha/action_list/heading.rb | 2 +- test/components/alpha/action_list_test.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/components/primer/alpha/action_list/heading.rb b/app/components/primer/alpha/action_list/heading.rb index a401a8c55e..a9fa0b2c5b 100644 --- a/app/components/primer/alpha/action_list/heading.rb +++ b/app/components/primer/alpha/action_list/heading.rb @@ -27,7 +27,7 @@ def initialize(list_id:, title:, heading_level: 3, scheme: DEFAULT_SCHEME, subti @heading_level = heading_level @tag = :"h#{heading_level}" - @system_arguments = system_arguments + @system_arguments = deny_tag_argument(**system_arguments) @list_id = list_id @title = title @subtitle = subtitle diff --git a/test/components/alpha/action_list_test.rb b/test/components/alpha/action_list_test.rb index ce6c4781f0..71be3e0dd7 100644 --- a/test/components/alpha/action_list_test.rb +++ b/test/components/alpha/action_list_test.rb @@ -79,6 +79,16 @@ def test_renders_leading_visuals assert_selector(".ActionListItem-visual--leading", count: 2) end + + def test_heading_denies_tag_argument + error = assert_raises ArgumentError do + render_inline(Primer::Alpha::ActionList.new(aria: { lable: "List" })) do |component| + component.with_heading(title: "Foo", tag: :foo) + end + end + + assert_match /This component has a fixed tag/, error.message + end end end end From 48de1873edeb886b555cba3e34f3d38ce95368de Mon Sep 17 00:00:00 2001 From: Cameron Dutro Date: Tue, 7 Mar 2023 15:35:13 -0800 Subject: [PATCH 2/2] Fix linting issues; add changeset --- .changeset/seven-tables-applaud.md | 5 +++++ test/components/alpha/action_list_test.rb | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/seven-tables-applaud.md diff --git a/.changeset/seven-tables-applaud.md b/.changeset/seven-tables-applaud.md new file mode 100644 index 0000000000..e247a8152d --- /dev/null +++ b/.changeset/seven-tables-applaud.md @@ -0,0 +1,5 @@ +--- +'@primer/view-components': patch +--- + +Deny tag argument for ActionList headings diff --git a/test/components/alpha/action_list_test.rb b/test/components/alpha/action_list_test.rb index 71be3e0dd7..3d7992d4b3 100644 --- a/test/components/alpha/action_list_test.rb +++ b/test/components/alpha/action_list_test.rb @@ -87,7 +87,7 @@ def test_heading_denies_tag_argument end end - assert_match /This component has a fixed tag/, error.message + assert_match(/This component has a fixed tag/, error.message) end end end