From 1753b90cf92121d937e60e5083fb409cac197bb6 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 17:54:18 +0000 Subject: [PATCH 01/16] Remove deprecated Primer::Dropdown --- app/components/primer/dropdown.rb | 7 ------- app/components/primer/dropdown/menu.rb | 14 -------------- lib/primer/deprecations.yml | 12 ------------ static/audited_at.json | 3 --- static/constants.json | 8 -------- static/statuses.json | 3 --- test/components/component_test.rb | 4 +--- 7 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 app/components/primer/dropdown.rb delete mode 100644 app/components/primer/dropdown/menu.rb diff --git a/app/components/primer/dropdown.rb b/app/components/primer/dropdown.rb deleted file mode 100644 index d54a3e2a3c..0000000000 --- a/app/components/primer/dropdown.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class Dropdown < Primer::Alpha::Dropdown - status :deprecated - end -end diff --git a/app/components/primer/dropdown/menu.rb b/app/components/primer/dropdown/menu.rb deleted file mode 100644 index 3bd9b815dd..0000000000 --- a/app/components/primer/dropdown/menu.rb +++ /dev/null @@ -1,14 +0,0 @@ -# frozen_string_literal: true - -module Primer - class Dropdown - # :nodoc: - class Menu < Primer::Alpha::Dropdown::Menu - status :deprecated - - class Item < Primer::Alpha::Dropdown::Menu::Item - status :deprecated - end - end - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 27618287cd..6cd3ed09e8 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -22,18 +22,6 @@ deprecations: replacement: "Primer::Beta::Button" guide: "https://primer.style/view-components/guides/primer_button_component" - - component: "Primer::Dropdown" - autocorrect: true - replacement: "Primer::Alpha::Dropdown" - - - component: "Primer::Dropdown::Menu" - autocorrect: true - replacement: "Primer::Alpha::Dropdown::Menu" - - - component: "Primer::Dropdown::Menu::Item" - autocorrect: true - replacement: "Primer::Alpha::Dropdown::Menu::Item" - - component: "Primer::HellipButton" autocorrect: true replacement: "Primer::Alpha::HellipButton" diff --git a/static/audited_at.json b/static/audited_at.json index 1724482e0b..cd77409c4c 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -76,9 +76,6 @@ "Primer::ButtonComponent": "", "Primer::ConditionalWrapper": "", "Primer::Content": "", - "Primer::Dropdown": "", - "Primer::Dropdown::Menu": "", - "Primer::Dropdown::Menu::Item": "", "Primer::HellipButton": "", "Primer::IconButton": "", "Primer::LabelComponent": "", diff --git a/static/constants.json b/static/constants.json index 260524d9e4..6aa09b8011 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1033,14 +1033,6 @@ }, "Primer::Content": { }, - "Primer::Dropdown": { - "Menu": "Primer::Dropdown::Menu" - }, - "Primer::Dropdown::Menu": { - "Item": "Primer::Dropdown::Menu::Item" - }, - "Primer::Dropdown::Menu::Item": { - }, "Primer::HellipButton": { }, "Primer::IconButton": { diff --git a/static/statuses.json b/static/statuses.json index 34898e208a..5f59ea73e8 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -76,9 +76,6 @@ "Primer::ButtonComponent": "deprecated", "Primer::ConditionalWrapper": "alpha", "Primer::Content": "stable", - "Primer::Dropdown": "deprecated", - "Primer::Dropdown::Menu": "deprecated", - "Primer::Dropdown::Menu::Item": "deprecated", "Primer::HellipButton": "deprecated", "Primer::IconButton": "deprecated", "Primer::LabelComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 22b7129d8f..8fdc5211c5 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -129,9 +129,7 @@ def test_registered_components "Primer::Component", "Primer::OcticonsSymbolComponent", "Primer::Content", - "Primer::PopoverComponent", - "Primer::Dropdown", - "Primer::Dropdown::Menu" + "Primer::PopoverComponent" ] primer_component_files_count = Dir["app/components/**/*.rb"].count { |p| p.exclude?("/experimental/") } From 3453e16b66d82343c1f59d1ddaee24a6d86e1103 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 17:55:45 +0000 Subject: [PATCH 02/16] Remove deprecated Primer::HellipButton --- app/components/primer/hellip_button.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/hellip_button.rb diff --git a/app/components/primer/hellip_button.rb b/app/components/primer/hellip_button.rb deleted file mode 100644 index ca89d854e5..0000000000 --- a/app/components/primer/hellip_button.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class HellipButton < Primer::Alpha::HellipButton - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 6cd3ed09e8..d94ed20163 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -22,10 +22,6 @@ deprecations: replacement: "Primer::Beta::Button" guide: "https://primer.style/view-components/guides/primer_button_component" - - component: "Primer::HellipButton" - autocorrect: true - replacement: "Primer::Alpha::HellipButton" - - component: "Primer::IconButton" autocorrect: true replacement: "Primer::Beta::IconButton" diff --git a/static/audited_at.json b/static/audited_at.json index cd77409c4c..4867ae924e 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -76,7 +76,6 @@ "Primer::ButtonComponent": "", "Primer::ConditionalWrapper": "", "Primer::Content": "", - "Primer::HellipButton": "", "Primer::IconButton": "", "Primer::LabelComponent": "", "Primer::LayoutComponent": "", diff --git a/static/constants.json b/static/constants.json index 6aa09b8011..65c8944663 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1033,8 +1033,6 @@ }, "Primer::Content": { }, - "Primer::HellipButton": { - }, "Primer::IconButton": { "DEFAULT_SCHEME": "default", "SCHEME_MAPPINGS": { diff --git a/static/statuses.json b/static/statuses.json index 5f59ea73e8..d376442013 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -76,7 +76,6 @@ "Primer::ButtonComponent": "deprecated", "Primer::ConditionalWrapper": "alpha", "Primer::Content": "stable", - "Primer::HellipButton": "deprecated", "Primer::IconButton": "deprecated", "Primer::LabelComponent": "deprecated", "Primer::LayoutComponent": "alpha", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 8fdc5211c5..d53aaf6678 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -113,7 +113,6 @@ def test_registered_components "Primer::TimelineItemComponent", "Primer::SubheadComponent", "Primer::TabContainerComponent", - "Primer::HellipButton", "Primer::StateComponent", "Primer::OcticonSymbolsComponent", "Primer::SpinnerComponent", From 077336bf6a90ba2685a0b1ce5f0d731bbc595231 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 17:57:52 +0000 Subject: [PATCH 03/16] Removing deprecated Primer::LabelComponent --- app/components/primer/label_component.rb | 7 ------- docs/contributors/deprecations.md | 10 +++++----- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 7 files changed, 5 insertions(+), 21 deletions(-) delete mode 100644 app/components/primer/label_component.rb diff --git a/app/components/primer/label_component.rb b/app/components/primer/label_component.rb deleted file mode 100644 index 532c14a6c1..0000000000 --- a/app/components/primer/label_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class LabelComponent < Primer::Beta::Label - status :deprecated - end -end diff --git a/docs/contributors/deprecations.md b/docs/contributors/deprecations.md index 05192a733e..df605cb701 100644 --- a/docs/contributors/deprecations.md +++ b/docs/contributors/deprecations.md @@ -71,18 +71,18 @@ configurations for more information. 1. An autocorrectable deprecation without a migration guide ```yml - - component: "Primer::LabelComponent" + - component: "Primer::DeprecatedComponent" autocorrect: true - replacement: "Primer::Beta::Label + replacement: "Primer::Beta::Component ``` 2. An autocorrectable deprecation with a migration guide to provide more information about the changes ```yml - - component: "Primer::LabelComponent" + - component: "Primer::DeprecatedComponent" autocorrect: true - replacement: "Primer::Beta::Label - guide: "https://example.com/label_component" + replacement: "Primer::Beta::Component + guide: "https://example.com/primer_component" ``` 3. A non-autocorrectable deprecation, with a replacement component and migration guide diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index d94ed20163..404437e0a0 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -26,10 +26,6 @@ deprecations: autocorrect: true replacement: "Primer::Beta::IconButton" - - component: "Primer::LabelComponent" - autocorrect: true - replacement: "Primer::Beta::Label" - - component: "Primer::LocalTime" autocorrect: false replacement: "Primer::Beta::RelativeTime" diff --git a/static/audited_at.json b/static/audited_at.json index 4867ae924e..f8ebfc41bd 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -77,7 +77,6 @@ "Primer::ConditionalWrapper": "", "Primer::Content": "", "Primer::IconButton": "", - "Primer::LabelComponent": "", "Primer::LayoutComponent": "", "Primer::LinkComponent": "", "Primer::LocalTime": "", diff --git a/static/constants.json b/static/constants.json index 65c8944663..85b358728c 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1044,8 +1044,6 @@ "danger" ] }, - "Primer::LabelComponent": { - }, "Primer::LayoutComponent": { "ALLOWED_SIDEBAR_COLS": [ 1, diff --git a/static/statuses.json b/static/statuses.json index d376442013..134aa8ed97 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -77,7 +77,6 @@ "Primer::ConditionalWrapper": "alpha", "Primer::Content": "stable", "Primer::IconButton": "deprecated", - "Primer::LabelComponent": "deprecated", "Primer::LayoutComponent": "alpha", "Primer::LinkComponent": "deprecated", "Primer::LocalTime": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index d53aaf6678..d50d9752f7 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -119,7 +119,6 @@ def test_registered_components "Primer::OcticonComponent", "Primer::Markdown", "Primer::MenuComponent", - "Primer::LabelComponent", "Primer::LinkComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", From d0621758fd7dab29adddeef0e1669f01e9c7a9a7 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 17:59:35 +0000 Subject: [PATCH 04/16] Removing deprecated Primer::LinkComponent --- app/components/primer/link_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/link_component.rb diff --git a/app/components/primer/link_component.rb b/app/components/primer/link_component.rb deleted file mode 100644 index b1728e91a0..0000000000 --- a/app/components/primer/link_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class LinkComponent < Primer::Beta::Link - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 404437e0a0..58f89fed11 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::LinkComponent" - autocorrect: true - replacement: "Primer::Beta::Link" - - component: "Primer::Markdown" autocorrect: true replacement: "Primer::Beta::Markdown" diff --git a/static/audited_at.json b/static/audited_at.json index f8ebfc41bd..b34086ab53 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -78,7 +78,6 @@ "Primer::Content": "", "Primer::IconButton": "", "Primer::LayoutComponent": "", - "Primer::LinkComponent": "", "Primer::LocalTime": "", "Primer::Markdown": "", "Primer::MenuComponent": "", diff --git a/static/constants.json b/static/constants.json index 85b358728c..abbf42e5e1 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1066,8 +1066,6 @@ "DEFAULT_SIDEBAR_COL": 3, "MAX_COL": 12 }, - "Primer::LinkComponent": { - }, "Primer::LocalTime": { "DEFAULT_DIGIT_TYPE": "numeric", "DEFAULT_TEXT_TYPE": "short", diff --git a/static/statuses.json b/static/statuses.json index 134aa8ed97..6996bac654 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -78,7 +78,6 @@ "Primer::Content": "stable", "Primer::IconButton": "deprecated", "Primer::LayoutComponent": "alpha", - "Primer::LinkComponent": "deprecated", "Primer::LocalTime": "deprecated", "Primer::Markdown": "deprecated", "Primer::MenuComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index d50d9752f7..9dffc4d050 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -119,7 +119,6 @@ def test_registered_components "Primer::OcticonComponent", "Primer::Markdown", "Primer::MenuComponent", - "Primer::LinkComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From 3d9ceaddc92d7a9d334f294a5968e31af4aafe8b Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:02:59 +0000 Subject: [PATCH 05/16] Removing deprecated Primer::Markdown --- app/components/primer/markdown.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/markdown.rb diff --git a/app/components/primer/markdown.rb b/app/components/primer/markdown.rb deleted file mode 100644 index bdb8c13a86..0000000000 --- a/app/components/primer/markdown.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class Markdown < Primer::Beta::Markdown - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 58f89fed11..a000a69065 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::Markdown" - autocorrect: true - replacement: "Primer::Beta::Markdown" - - component: "Primer::MenuComponent" autocorrect: true replacement: "Primer::Alpha::Menu" diff --git a/static/audited_at.json b/static/audited_at.json index b34086ab53..c932ba09a2 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -79,7 +79,6 @@ "Primer::IconButton": "", "Primer::LayoutComponent": "", "Primer::LocalTime": "", - "Primer::Markdown": "", "Primer::MenuComponent": "", "Primer::Navigation::TabComponent": "", "Primer::OcticonComponent": "", diff --git a/static/constants.json b/static/constants.json index abbf42e5e1..7a1cef8d81 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1078,8 +1078,6 @@ "long" ] }, - "Primer::Markdown": { - }, "Primer::MenuComponent": { }, "Primer::Navigation::TabComponent": { diff --git a/static/statuses.json b/static/statuses.json index 6996bac654..abca20d75a 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -79,7 +79,6 @@ "Primer::IconButton": "deprecated", "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", - "Primer::Markdown": "deprecated", "Primer::MenuComponent": "deprecated", "Primer::Navigation::TabComponent": "alpha", "Primer::OcticonComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 9dffc4d050..af9ea5f095 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -117,7 +117,6 @@ def test_registered_components "Primer::OcticonSymbolsComponent", "Primer::SpinnerComponent", "Primer::OcticonComponent", - "Primer::Markdown", "Primer::MenuComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", From 471d170101b0fff3ff7bd9db27acf98a8ce4d741 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:08:20 +0000 Subject: [PATCH 06/16] Removing deprecated Primer::MenuComponent --- app/components/primer/menu_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/menu_component.rb diff --git a/app/components/primer/menu_component.rb b/app/components/primer/menu_component.rb deleted file mode 100644 index 632bf4d6ed..0000000000 --- a/app/components/primer/menu_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class MenuComponent < Primer::Alpha::Menu - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index a000a69065..3cb40d25ef 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::MenuComponent" - autocorrect: true - replacement: "Primer::Alpha::Menu" - - component: "Primer::OcticonComponent" autocorrect: true replacement: "Primer::Beta::Octicon" diff --git a/static/audited_at.json b/static/audited_at.json index c932ba09a2..baf3bfa7cb 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -79,7 +79,6 @@ "Primer::IconButton": "", "Primer::LayoutComponent": "", "Primer::LocalTime": "", - "Primer::MenuComponent": "", "Primer::Navigation::TabComponent": "", "Primer::OcticonComponent": "", "Primer::OcticonSymbolsComponent": "", diff --git a/static/constants.json b/static/constants.json index 7a1cef8d81..32ce39f9ec 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1078,8 +1078,6 @@ "long" ] }, - "Primer::MenuComponent": { - }, "Primer::Navigation::TabComponent": { "ARIA_CURRENT_OPTIONS_FOR_ANCHOR": [ true, diff --git a/static/statuses.json b/static/statuses.json index abca20d75a..3df7867c0e 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -79,7 +79,6 @@ "Primer::IconButton": "deprecated", "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", - "Primer::MenuComponent": "deprecated", "Primer::Navigation::TabComponent": "alpha", "Primer::OcticonComponent": "deprecated", "Primer::OcticonSymbolsComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index af9ea5f095..75c9f2143c 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -117,7 +117,6 @@ def test_registered_components "Primer::OcticonSymbolsComponent", "Primer::SpinnerComponent", "Primer::OcticonComponent", - "Primer::MenuComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From a8ee0a33faf6e43cc34761f5c8f5ec74c4f203dc Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:11:43 +0000 Subject: [PATCH 07/16] Removing deprecated Primer::OcticonComponent --- app/components/primer/octicon_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/octicon_component.rb diff --git a/app/components/primer/octicon_component.rb b/app/components/primer/octicon_component.rb deleted file mode 100644 index 915ce1ba6c..0000000000 --- a/app/components/primer/octicon_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class OcticonComponent < Primer::Beta::Octicon - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 3cb40d25ef..bfca6d4348 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::OcticonComponent" - autocorrect: true - replacement: "Primer::Beta::Octicon" - - component: "Primer::OcticonSymbolsComponent" autocorrect: true replacement: "Primer::Alpha::OcticonSymbols" diff --git a/static/audited_at.json b/static/audited_at.json index baf3bfa7cb..8b4c8f12da 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::OcticonComponent": "", "Primer::OcticonSymbolsComponent": "", "Primer::PopoverComponent": "", "Primer::SpinnerComponent": "", diff --git a/static/constants.json b/static/constants.json index 32ce39f9ec..77aa0a38c2 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::OcticonComponent": { - }, "Primer::OcticonSymbolsComponent": { }, "Primer::PopoverComponent": { diff --git a/static/statuses.json b/static/statuses.json index 3df7867c0e..547e9699ab 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::OcticonComponent": "deprecated", "Primer::OcticonSymbolsComponent": "deprecated", "Primer::PopoverComponent": "deprecated", "Primer::SpinnerComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 75c9f2143c..9091fc1ca6 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -116,7 +116,6 @@ def test_registered_components "Primer::StateComponent", "Primer::OcticonSymbolsComponent", "Primer::SpinnerComponent", - "Primer::OcticonComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From c22a9ce27a740de36b995b9a90042d2cca64b213 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:13:24 +0000 Subject: [PATCH 08/16] Remove deprecated Primer::OcticonSymbolsComponent --- app/components/primer/octicon_symbols_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 2 -- 6 files changed, 17 deletions(-) delete mode 100644 app/components/primer/octicon_symbols_component.rb diff --git a/app/components/primer/octicon_symbols_component.rb b/app/components/primer/octicon_symbols_component.rb deleted file mode 100644 index a2db3766ad..0000000000 --- a/app/components/primer/octicon_symbols_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class OcticonSymbolsComponent < Primer::Alpha::OcticonSymbols - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index bfca6d4348..372949cd32 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::OcticonSymbolsComponent" - autocorrect: true - replacement: "Primer::Alpha::OcticonSymbols" - - component: "Primer::PopoverComponent" autocorrect: true replacement: "Primer::Beta::Popover" diff --git a/static/audited_at.json b/static/audited_at.json index 8b4c8f12da..468db6d5ed 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::OcticonSymbolsComponent": "", "Primer::PopoverComponent": "", "Primer::SpinnerComponent": "", "Primer::StateComponent": "", diff --git a/static/constants.json b/static/constants.json index 77aa0a38c2..c987d1e1f2 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::OcticonSymbolsComponent": { - }, "Primer::PopoverComponent": { }, "Primer::SpinnerComponent": { diff --git a/static/statuses.json b/static/statuses.json index 547e9699ab..5bd588c181 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::OcticonSymbolsComponent": "deprecated", "Primer::PopoverComponent": "deprecated", "Primer::SpinnerComponent": "deprecated", "Primer::StateComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 9091fc1ca6..a60626164a 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -114,14 +114,12 @@ def test_registered_components "Primer::SubheadComponent", "Primer::TabContainerComponent", "Primer::StateComponent", - "Primer::OcticonSymbolsComponent", "Primer::SpinnerComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", "Primer::Alpha::NavList::Section", "Primer::Component", - "Primer::OcticonsSymbolComponent", "Primer::Content", "Primer::PopoverComponent" ] From f62b5b9e23815fe1f58114ce072659d71f678246 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:15:22 +0000 Subject: [PATCH 09/16] Removing deprecated Primer::PopoverComponent --- app/components/primer/popover_component.rb | 8 -------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 3 +-- 6 files changed, 1 insertion(+), 18 deletions(-) delete mode 100644 app/components/primer/popover_component.rb diff --git a/app/components/primer/popover_component.rb b/app/components/primer/popover_component.rb deleted file mode 100644 index 96447b756c..0000000000 --- a/app/components/primer/popover_component.rb +++ /dev/null @@ -1,8 +0,0 @@ -# frozen_string_literal: true - -module Primer - # :nodoc: - class PopoverComponent < Primer::Beta::Popover - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 372949cd32..049079ab03 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::PopoverComponent" - autocorrect: true - replacement: "Primer::Beta::Popover" - - component: "Primer::SpinnerComponent" autocorrect: true replacement: "Primer::Beta::Spinner" diff --git a/static/audited_at.json b/static/audited_at.json index 468db6d5ed..665747fa1e 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::PopoverComponent": "", "Primer::SpinnerComponent": "", "Primer::StateComponent": "", "Primer::SubheadComponent": "", diff --git a/static/constants.json b/static/constants.json index c987d1e1f2..9585285ef4 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::PopoverComponent": { - }, "Primer::SpinnerComponent": { }, "Primer::StateComponent": { diff --git a/static/statuses.json b/static/statuses.json index 5bd588c181..75e2378556 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::PopoverComponent": "deprecated", "Primer::SpinnerComponent": "deprecated", "Primer::StateComponent": "deprecated", "Primer::SubheadComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index a60626164a..6a05f5ea6a 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -120,8 +120,7 @@ def test_registered_components "Primer::Alpha::ActionList::Separator", "Primer::Alpha::NavList::Section", "Primer::Component", - "Primer::Content", - "Primer::PopoverComponent" + "Primer::Content" ] primer_component_files_count = Dir["app/components/**/*.rb"].count { |p| p.exclude?("/experimental/") } From 4c684f6496893f78036669756403796031160f27 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:20:28 +0000 Subject: [PATCH 10/16] Remove deprecated Primer::SpinnerComponent --- app/components/primer/spinner_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/spinner_component.rb diff --git a/app/components/primer/spinner_component.rb b/app/components/primer/spinner_component.rb deleted file mode 100644 index 00eaf60db5..0000000000 --- a/app/components/primer/spinner_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class SpinnerComponent < Primer::Beta::Spinner - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 049079ab03..571f3080aa 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::SpinnerComponent" - autocorrect: true - replacement: "Primer::Beta::Spinner" - - component: "Primer::StateComponent" autocorrect: true replacement: "Primer::Beta::State" diff --git a/static/audited_at.json b/static/audited_at.json index 665747fa1e..d8db8f87db 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::SpinnerComponent": "", "Primer::StateComponent": "", "Primer::SubheadComponent": "", "Primer::TabContainerComponent": "", diff --git a/static/constants.json b/static/constants.json index 9585285ef4..ef0d8a7b08 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::SpinnerComponent": { - }, "Primer::StateComponent": { }, "Primer::SubheadComponent": { diff --git a/static/statuses.json b/static/statuses.json index 75e2378556..80b7faee48 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::SpinnerComponent": "deprecated", "Primer::StateComponent": "deprecated", "Primer::SubheadComponent": "deprecated", "Primer::TabContainerComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 6a05f5ea6a..9545d70a3a 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -114,7 +114,6 @@ def test_registered_components "Primer::SubheadComponent", "Primer::TabContainerComponent", "Primer::StateComponent", - "Primer::SpinnerComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From 0730cfe4dafe2c8c5622328bd53adf6eb981b009 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:21:51 +0000 Subject: [PATCH 11/16] Removing deprecated Primer::StateComponent --- app/components/primer/state_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/state_component.rb diff --git a/app/components/primer/state_component.rb b/app/components/primer/state_component.rb deleted file mode 100644 index 2a4ac2bc98..0000000000 --- a/app/components/primer/state_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class StateComponent < Primer::Beta::State - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 571f3080aa..48e385f169 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::StateComponent" - autocorrect: true - replacement: "Primer::Beta::State" - - component: "Primer::SubheadComponent" autocorrect: true replacement: "Primer::Beta::Subhead" diff --git a/static/audited_at.json b/static/audited_at.json index d8db8f87db..1df34df058 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::StateComponent": "", "Primer::SubheadComponent": "", "Primer::TabContainerComponent": "", "Primer::TimeAgoComponent": "", diff --git a/static/constants.json b/static/constants.json index ef0d8a7b08..86eec630fc 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::StateComponent": { - }, "Primer::SubheadComponent": { }, "Primer::TabContainerComponent": { diff --git a/static/statuses.json b/static/statuses.json index 80b7faee48..5b8247a83b 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::StateComponent": "deprecated", "Primer::SubheadComponent": "deprecated", "Primer::TabContainerComponent": "deprecated", "Primer::TimeAgoComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 9545d70a3a..68a226ea83 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -113,7 +113,6 @@ def test_registered_components "Primer::TimelineItemComponent", "Primer::SubheadComponent", "Primer::TabContainerComponent", - "Primer::StateComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From 724b394ae25b7fcdce9be6bea37cf650404e25ba Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:22:42 +0000 Subject: [PATCH 12/16] Remove deprecated Primer::SubheadComponent --- app/components/primer/subhead_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/subhead_component.rb diff --git a/app/components/primer/subhead_component.rb b/app/components/primer/subhead_component.rb deleted file mode 100644 index 9c0d069d3c..0000000000 --- a/app/components/primer/subhead_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class SubheadComponent < Primer::Beta::Subhead - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 48e385f169..2ca8da33d7 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::SubheadComponent" - autocorrect: true - replacement: "Primer::Beta::Subhead" - - component: "Primer::TabContainerComponent" autocorrect: true replacement: "Primer::Alpha::TabContainer" diff --git a/static/audited_at.json b/static/audited_at.json index 1df34df058..8fff741563 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::SubheadComponent": "", "Primer::TabContainerComponent": "", "Primer::TimeAgoComponent": "", "Primer::TimelineItemComponent": "", diff --git a/static/constants.json b/static/constants.json index 86eec630fc..5b553097b0 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::SubheadComponent": { - }, "Primer::TabContainerComponent": { }, "Primer::TimeAgoComponent": { diff --git a/static/statuses.json b/static/statuses.json index 5b8247a83b..ddccbb7e88 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::SubheadComponent": "deprecated", "Primer::TabContainerComponent": "deprecated", "Primer::TimeAgoComponent": "deprecated", "Primer::TimelineItemComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 68a226ea83..361cf37d34 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -111,7 +111,6 @@ class PrimerComponentTest < Minitest::Test def test_registered_components ignored_components = [ "Primer::TimelineItemComponent", - "Primer::SubheadComponent", "Primer::TabContainerComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", From f93ffcbdf4b14138528f21a6a5bff6be8195cef9 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:25:25 +0000 Subject: [PATCH 13/16] Remove deprecated Primer::TabContainerComponent --- app/components/primer/tab_container_component.rb | 7 ------- lib/primer/deprecations.yml | 4 ---- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 6 files changed, 16 deletions(-) delete mode 100644 app/components/primer/tab_container_component.rb diff --git a/app/components/primer/tab_container_component.rb b/app/components/primer/tab_container_component.rb deleted file mode 100644 index f35a334cf5..0000000000 --- a/app/components/primer/tab_container_component.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class TabContainerComponent < Primer::Alpha::TabContainer - status :deprecated - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index 2ca8da33d7..cce4561f33 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -31,10 +31,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_local_time" - - component: "Primer::TabContainerComponent" - autocorrect: true - replacement: "Primer::Alpha::TabContainer" - - component: "Primer::TimeAgoComponent" autocorrect: false replacement: "Primer::Beta::RelativeTime" diff --git a/static/audited_at.json b/static/audited_at.json index 8fff741563..490a76228b 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "", "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", - "Primer::TabContainerComponent": "", "Primer::TimeAgoComponent": "", "Primer::TimelineItemComponent": "", "Primer::TimelineItemComponent::BadgeComponent": "", diff --git a/static/constants.json b/static/constants.json index 5b553097b0..bbda4fe935 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1085,8 +1085,6 @@ ], "DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page" }, - "Primer::TabContainerComponent": { - }, "Primer::TimeAgoComponent": { }, "Primer::TimelineItemComponent": { diff --git a/static/statuses.json b/static/statuses.json index ddccbb7e88..d15b4a4ba6 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -80,7 +80,6 @@ "Primer::LayoutComponent": "alpha", "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", - "Primer::TabContainerComponent": "deprecated", "Primer::TimeAgoComponent": "deprecated", "Primer::TimelineItemComponent": "deprecated", "Primer::TimelineItemComponent::BadgeComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 361cf37d34..8fe3497b35 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -111,7 +111,6 @@ class PrimerComponentTest < Minitest::Test def test_registered_components ignored_components = [ "Primer::TimelineItemComponent", - "Primer::TabContainerComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From e07906146923003c966220bad1233b798df9f7bf Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 18:27:12 +0000 Subject: [PATCH 14/16] Remove deprecated Primer::TimelineItemComponent --- app/components/primer/timeline_item_component.rb | 13 ------------- lib/primer/deprecations.yml | 8 -------- static/audited_at.json | 2 -- static/constants.json | 5 ----- static/statuses.json | 2 -- test/components/component_test.rb | 1 - 6 files changed, 31 deletions(-) delete mode 100644 app/components/primer/timeline_item_component.rb diff --git a/app/components/primer/timeline_item_component.rb b/app/components/primer/timeline_item_component.rb deleted file mode 100644 index a72f7994c9..0000000000 --- a/app/components/primer/timeline_item_component.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -module Primer - # nodoc - class TimelineItemComponent < Primer::Beta::TimelineItem - status :deprecated - - # nodoc - class BadgeComponent < Primer::Component - status :deprecated - end - end -end diff --git a/lib/primer/deprecations.yml b/lib/primer/deprecations.yml index cce4561f33..5fbd1c1cbd 100644 --- a/lib/primer/deprecations.yml +++ b/lib/primer/deprecations.yml @@ -36,14 +36,6 @@ deprecations: replacement: "Primer::Beta::RelativeTime" guide: "https://primer.style/view-components/guides/primer_time_ago" - - component: "Primer::TimelineItemComponent" - autocorrect: true - replacement: "Primer::Beta::TimelineItem" - - - component: "Primer::TimelineItemComponent::BadgeComponent" - autocorrect: true - replacement: "Primer::Beta::TimelineItem::Badge" - - component: "Primer::Tooltip" autocorrect: true replacement: "Primer::Alpha::Tooltip" diff --git a/static/audited_at.json b/static/audited_at.json index 490a76228b..132982674a 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -81,8 +81,6 @@ "Primer::LocalTime": "", "Primer::Navigation::TabComponent": "", "Primer::TimeAgoComponent": "", - "Primer::TimelineItemComponent": "", - "Primer::TimelineItemComponent::BadgeComponent": "", "Primer::Tooltip": "", "Primer::Truncate": "" } diff --git a/static/constants.json b/static/constants.json index bbda4fe935..47bc9c4478 100644 --- a/static/constants.json +++ b/static/constants.json @@ -1087,11 +1087,6 @@ }, "Primer::TimeAgoComponent": { }, - "Primer::TimelineItemComponent": { - "BadgeComponent": "Primer::TimelineItemComponent::BadgeComponent" - }, - "Primer::TimelineItemComponent::BadgeComponent": { - }, "Primer::Tooltip": { "ALIGN_DEFAULT": "default", "ALIGN_MAPPING": { diff --git a/static/statuses.json b/static/statuses.json index d15b4a4ba6..03b3336804 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -81,8 +81,6 @@ "Primer::LocalTime": "deprecated", "Primer::Navigation::TabComponent": "alpha", "Primer::TimeAgoComponent": "deprecated", - "Primer::TimelineItemComponent": "deprecated", - "Primer::TimelineItemComponent::BadgeComponent": "deprecated", "Primer::Tooltip": "deprecated", "Primer::Truncate": "beta" } diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 8fe3497b35..0ea7833e94 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -110,7 +110,6 @@ class PrimerComponentTest < Minitest::Test def test_registered_components ignored_components = [ - "Primer::TimelineItemComponent", "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", "Primer::Alpha::ActionList::Separator", From 0cc10c09cf753b686a9a0914223615b9e0c2e691 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 19:05:53 +0000 Subject: [PATCH 15/16] Fixing component_test --- test/components/component_test.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/components/component_test.rb b/test/components/component_test.rb index 0ea7833e94..3e5a13159b 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -103,7 +103,6 @@ class PrimerComponentTest < Minitest::Test [Primer::Tooltip, { label: "More" }], [Primer::Alpha::UnderlineNav, { label: "aria label" }, proc { |component| component.with_tab(selected: true) { "Foo" } }], [Primer::Alpha::Tooltip, { type: :label, for_id: "some-button", text: "Foo" }], - [Primer::Alpha::ActionList, { aria: { label: "Nav list" } }], [Primer::Alpha::NavList, { aria: { label: "Nav list" } }], [Primer::Alpha::Banner, {}] ].freeze @@ -112,8 +111,10 @@ def test_registered_components ignored_components = [ "Primer::Alpha::ActionList::Heading", "Primer::Alpha::ActionList::Item", - "Primer::Alpha::ActionList::Separator", + "Primer::Alpha::ActionList::Divider", + "Primer::Alpha::NavList::Item", "Primer::Alpha::NavList::Section", + "Primer::Alpha::OcticonSymbols", "Primer::Component", "Primer::Content" ] From ba4940e25686c18019d23ddd9901e6815868d978 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 27 Jan 2023 11:08:18 -0800 Subject: [PATCH 16/16] Create .changeset/shiny-actors-share.md --- .changeset/shiny-actors-share.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .changeset/shiny-actors-share.md diff --git a/.changeset/shiny-actors-share.md b/.changeset/shiny-actors-share.md new file mode 100644 index 0000000000..843f512d25 --- /dev/null +++ b/.changeset/shiny-actors-share.md @@ -0,0 +1,23 @@ +--- +"@primer/view-components": patch +--- + +Remove unused deprecated component wrappers + + - "Primer::Dropdown::Menu::Item" + - "Primer::Dropdown::Menu" + - "Primer::Dropdown" + - "Primer::HellipButton" + - "Primer::LabelComponent" + - "Primer::LinkComponent" + - "Primer::Markdown" + - "Primer::MenuComponent" + - "Primer::OcticonComponent" + - "Primer::OcticonSymbolsComponent" + - "Primer::PopoverComponent" + - "Primer::SpinnerComponent" + - "Primer::StateComponent" + - "Primer::SubheadComponent" + - "Primer::TabContainerComponent" + - "Primer::TimelineItemComponent::BadgeComponent" + - "Primer::TimelineItemComponent"