From a2b2a4621eaa31439815e0a44081983589e25c54 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 7 Oct 2022 23:02:23 +0000 Subject: [PATCH 1/2] Removing deprecated Primer::CloseButton --- app/components/primer/close_button.rb | 7 ------- lib/primer/deprecations.rb | 1 - .../linters/close_button_component_migration_counter.rb | 2 +- static/audited_at.json | 1 - static/constants.json | 2 -- static/statuses.json | 1 - test/components/component_test.rb | 1 - 7 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 app/components/primer/close_button.rb diff --git a/app/components/primer/close_button.rb b/app/components/primer/close_button.rb deleted file mode 100644 index 7ea7b83547..0000000000 --- a/app/components/primer/close_button.rb +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -module Primer - class CloseButton < Primer::Beta::CloseButton - status :deprecated - end -end diff --git a/lib/primer/deprecations.rb b/lib/primer/deprecations.rb index 6b88378a84..f2c2c1a3db 100644 --- a/lib/primer/deprecations.rb +++ b/lib/primer/deprecations.rb @@ -9,7 +9,6 @@ module Deprecations "Primer::Alpha::AutoComplete::Item" => "Primer::Beta::AutoComplete::Item", "Primer::BlankslateComponent" => "Primer::Beta::Blankslate", "Primer::BoxComponent" => "Primer::Box", - "Primer::CloseButton" => "Primer::Beta::CloseButton", "Primer::CounterComponent" => "Primer::Beta::Counter", "Primer::DetailsComponent" => "Primer::Beta::Details", "Primer::DropdownMenuComponent" => nil, diff --git a/lib/primer/view_components/linters/close_button_component_migration_counter.rb b/lib/primer/view_components/linters/close_button_component_migration_counter.rb index 23497b3ae2..d9b5e7a82a 100644 --- a/lib/primer/view_components/linters/close_button_component_migration_counter.rb +++ b/lib/primer/view_components/linters/close_button_component_migration_counter.rb @@ -14,7 +14,7 @@ class CloseButtonComponentMigrationCounter < BaseLinter TAGS = %w[button].freeze CLASSES = %w[close-button].freeze - MESSAGE = "We are migrating close-button to use [Primer::Beta::CloseButton](https://primer.style/view-components/components/closebutton), please try to use that instead of raw HTML." + MESSAGE = "We are migrating close-button to use [Primer::Beta::CloseButton](https://primer.style/view-components/components/beta/closebutton), please try to use that instead of raw HTML." ARGUMENT_MAPPER = ArgumentMappers::CloseButton COMPONENT = "Primer::Beta::CloseButton" diff --git a/static/audited_at.json b/static/audited_at.json index 1549c52d35..076fb267c5 100644 --- a/static/audited_at.json +++ b/static/audited_at.json @@ -51,7 +51,6 @@ "Primer::BoxComponent": "", "Primer::ButtonComponent": "", "Primer::ClipboardCopy": "", - "Primer::CloseButton": "", "Primer::ConditionalWrapper": "", "Primer::Content": "", "Primer::CounterComponent": "", diff --git a/static/constants.json b/static/constants.json index 83364df322..df7970bf88 100644 --- a/static/constants.json +++ b/static/constants.json @@ -608,8 +608,6 @@ }, "Primer::ClipboardCopy": { }, - "Primer::CloseButton": { - }, "Primer::ConditionalWrapper": { }, "Primer::Content": { diff --git a/static/statuses.json b/static/statuses.json index e08325611d..4c160b936f 100644 --- a/static/statuses.json +++ b/static/statuses.json @@ -51,7 +51,6 @@ "Primer::BoxComponent": "deprecated", "Primer::ButtonComponent": "beta", "Primer::ClipboardCopy": "beta", - "Primer::CloseButton": "deprecated", "Primer::ConditionalWrapper": "alpha", "Primer::Content": "stable", "Primer::CounterComponent": "deprecated", diff --git a/test/components/component_test.rb b/test/components/component_test.rb index d3adc906b4..8045003cba 100644 --- a/test/components/component_test.rb +++ b/test/components/component_test.rb @@ -108,7 +108,6 @@ def test_registered_components "Primer::Alpha::NavList::Section", "Primer::HiddenTextExpander", "Primer::HeadingComponent", - "Primer::CloseButton", "Primer::CounterComponent", "Primer::DetailsComponent", "Primer::Component", From 68abe7dd11230a07eb7e1a01f139540364b4a427 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 7 Oct 2022 16:03:54 -0700 Subject: [PATCH 2/2] Create soft-horses-compare.md --- .changeset/soft-horses-compare.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/soft-horses-compare.md diff --git a/.changeset/soft-horses-compare.md b/.changeset/soft-horses-compare.md new file mode 100644 index 0000000000..d765e6ee11 --- /dev/null +++ b/.changeset/soft-horses-compare.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Removing the deprecated Primer::CloseButton component.