From d678ebaf108f26262b3691972348644da43faf02 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 5 Aug 2022 23:09:31 +0000 Subject: [PATCH 1/4] Always set `:absolute` position on Tooltip --- app/components/primer/alpha/tooltip.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/components/primer/alpha/tooltip.rb b/app/components/primer/alpha/tooltip.rb index 1ebd295209..7211320282 100644 --- a/app/components/primer/alpha/tooltip.rb +++ b/app/components/primer/alpha/tooltip.rb @@ -91,6 +91,7 @@ def initialize(type:, for_id:, text:, direction: DIRECTION_DEFAULT, **system_arg @system_arguments[:tag] = :"tool-tip" @system_arguments[:style] = join_style_arguments(@system_arguments[:style], "visibility: hidden") @system_arguments[:for] = for_id + @system_arguments[:position] = :absolute @system_arguments[:"data-direction"] = fetch_or_fallback(DIRECTION_OPTIONS, direction, DIRECTION_DEFAULT).to_s @system_arguments[:"data-type"] = fetch_or_fallback(TYPE_OPTIONS, type, TYPE_FALLBACK).to_s end From 9bd56eba55dd1988e88220adb2c2cac5282f7c65 Mon Sep 17 00:00:00 2001 From: Actions Auto Build Date: Fri, 5 Aug 2022 23:15:30 +0000 Subject: [PATCH 2/4] docs: build docs --- static/classes.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/static/classes.yml b/static/classes.yml index ed2aa620b3..0d0596eb96 100644 --- a/static/classes.yml +++ b/static/classes.yml @@ -212,6 +212,7 @@ - ".p-3" - ".p-4" - ".p-5" +- ".position-absolute" - ".position-relative" - ".pr-2" - ".pt-5" From 52534f4904b2e66563d91a56b864e2e8f9de7659 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 5 Aug 2022 23:17:39 +0000 Subject: [PATCH 3/4] Adding a test --- test/components/alpha/tooltip_test.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/components/alpha/tooltip_test.rb b/test/components/alpha/tooltip_test.rb index 6f9d5c630d..3bfc2c1622 100644 --- a/test/components/alpha/tooltip_test.rb +++ b/test/components/alpha/tooltip_test.rb @@ -29,4 +29,9 @@ def test_raises_if_text_is_not_string render_inline(Primer::Alpha::Tooltip.new(type: :description, for_id: "someButton", text: not_text, visible: false)) end end + + def test_tooltip_is_position_absolute + render_inline(Primer::Alpha::Tooltip.new(type: :description, for_id: "someButton", text: "Tooltip")) + assert_selector("tool-tip.position-absolute", visible: false) + end end From 8e0d3028fc9dce57718be31da4727a97796379db Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 5 Aug 2022 16:17:57 -0700 Subject: [PATCH 4/4] Create honest-vans-fold.md --- .changeset/honest-vans-fold.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/honest-vans-fold.md diff --git a/.changeset/honest-vans-fold.md b/.changeset/honest-vans-fold.md new file mode 100644 index 0000000000..d6e81fa63e --- /dev/null +++ b/.changeset/honest-vans-fold.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Always set `:absolute` position on Primer::Alpha::Tooltip