From 9a936bd18053f7f17d1c1146349a157b90c5c91e Mon Sep 17 00:00:00 2001 From: Katie Langerman Date: Wed, 12 Oct 2022 16:40:28 -0700 Subject: [PATCH] Remove dead SCSS code from ActionList (#1486) * remove dead code * Create shiny-kangaroos-enjoy.md * add back mixin * lint --- .changeset/shiny-kangaroos-enjoy.md | 5 +++++ app/components/primer/alpha/action_list/action-list.pcss | 9 ++++----- 2 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 .changeset/shiny-kangaroos-enjoy.md diff --git a/.changeset/shiny-kangaroos-enjoy.md b/.changeset/shiny-kangaroos-enjoy.md new file mode 100644 index 0000000000..2d44769a87 --- /dev/null +++ b/.changeset/shiny-kangaroos-enjoy.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Remove dead SCSS code from ActionList diff --git a/app/components/primer/alpha/action_list/action-list.pcss b/app/components/primer/alpha/action_list/action-list.pcss index 21d3eac4b0..a331e8c56e 100644 --- a/app/components/primer/alpha/action_list/action-list.pcss +++ b/app/components/primer/alpha/action_list/action-list.pcss @@ -185,11 +185,11 @@ visibility: hidden; } - /* blue accent line + /* blue accent line */ + &::after { - @include activeIndicatorLine(-$spacer-1); - @mixin activeIndicatorLine - } */ + @mixin activeIndicatorLine calc(-1 * var(--base-size-4, 4px)); + } } /* active state [aria-current] */ @@ -557,7 +557,6 @@ /* with children */ &:not(:empty) { display: flex; - padding: ($spacer-1 * 1.5) $spacer-2; padding-inline: var(--primer-actionListContent-paddingBlock); padding-block: var(--base-size-8, 8px); font-size: var(--primer-text-body-size-small, 12px);