diff --git a/.changeset/eleven-pillows-explain.md b/.changeset/eleven-pillows-explain.md new file mode 100644 index 0000000000..509da8910f --- /dev/null +++ b/.changeset/eleven-pillows-explain.md @@ -0,0 +1,7 @@ +--- +'@primer/view-components': patch +--- + +Fixing ActionBar more menu items including buttons with no type + + diff --git a/app/components/primer/alpha/action_bar.rb b/app/components/primer/alpha/action_bar.rb index 4842fb7353..79c3b65432 100644 --- a/app/components/primer/alpha/action_bar.rb +++ b/app/components/primer/alpha/action_bar.rb @@ -66,8 +66,6 @@ def with_menu_item(id:, **system_arguments, &block) system_arguments = { **system_arguments, hidden: true, - tag: :button, - type: "button", "data-for": id, "data-action": "click:action-bar#menuItemClick" } diff --git a/test/components/alpha/action_bar_test.rb b/test/components/alpha/action_bar_test.rb new file mode 100644 index 0000000000..cb409b315e --- /dev/null +++ b/test/components/alpha/action_bar_test.rb @@ -0,0 +1,19 @@ +# frozen_string_literal: true + +require "components/test_helper" + +module Primer + module Alpha + class ActionBarTest < Minitest::Test + include Primer::ComponentTestHelpers + + def test_renders_action_menu_items_with_type_button + render_preview(:default) + + assert_selector("action-menu[data-target=\"action-bar.moreMenu\"]", visible: :hidden) do + assert_selector("button[type=\"button\"]") + end + end + end + end +end