From 941e8394e7d61bcd97037fad30ff339fb216f218 Mon Sep 17 00:00:00 2001 From: Clay Miller Date: Fri, 18 Jun 2021 14:35:00 -0400 Subject: [PATCH 1/2] fix: Type 'DropdownButton' as 'button' --- src/DropdownMenu/DropdownButton.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DropdownMenu/DropdownButton.tsx b/src/DropdownMenu/DropdownButton.tsx index df2a7f36d87..450e6133429 100644 --- a/src/DropdownMenu/DropdownButton.tsx +++ b/src/DropdownMenu/DropdownButton.tsx @@ -7,7 +7,7 @@ export type DropdownButtonProps = ButtonProps export const DropdownButton = React.forwardRef>( ({children, ...props}: React.PropsWithChildren, ref): JSX.Element => ( - From 1099eef294cad99d4b241dfa1bde729e32dd9ee4 Mon Sep 17 00:00:00 2001 From: Clay Miller Date: Wed, 23 Jun 2021 12:32:43 -0400 Subject: [PATCH 2/2] chore: Update snapshots --- src/__tests__/__snapshots__/DropdownMenu.tsx.snap | 1 + src/__tests__/__snapshots__/SelectPanel.tsx.snap | 1 + 2 files changed, 2 insertions(+) diff --git a/src/__tests__/__snapshots__/DropdownMenu.tsx.snap b/src/__tests__/__snapshots__/DropdownMenu.tsx.snap index 0e1fd83dd83..ff413f760bd 100644 --- a/src/__tests__/__snapshots__/DropdownMenu.tsx.snap +++ b/src/__tests__/__snapshots__/DropdownMenu.tsx.snap @@ -79,6 +79,7 @@ exports[`DropdownMenu renders consistently 1`] = ` onClick={[Function]} onKeyDown={[Function]} tabIndex={0} + type="button" >