Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Pagination): Add e2e snapshot tests for pagination #5297

Merged
merged 3 commits into from
Nov 15, 2024
Merged

chore(Pagination): Add e2e snapshot tests for pagination #5297

merged 3 commits into from
Nov 15, 2024

Conversation

randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Nov 14, 2024 •
edited
Loading

Related To: https://github.com/github/primer/issues/4301

Add missing e2e snapshot tests for Pagination component in preparation for CSS Module migration

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 59a9635

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@randall-krauskopf randall-krauskopf changed the title add snapshot tests chore(Pagination): Add e2e snapshot tests for pagination Nov 14, 2024
@randall-krauskopf randall-krauskopf added the skip changeset This change does not need a changelog label Nov 14, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5297 November 14, 2024 17:21 Inactive
randall-krauskopf
randall-krauskopf commented Nov 14, 2024
View reviewed changes
packages/react/src/Pagination/Pagination.dev.stories.tsx
} as Meta<ComponentProps<typeof Pagination>>

export const DevDefault = () => (
<Pagination pageCount={15} currentPage={2} onPageChange={e => e.preventDefault()} showPages={{narrow: false}} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current Pagination component doesn't seem to support any custom styling around sx for style. Is this something we want to add as part of the CSS module migration work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na, if it's not supported we want to avoid adding it

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.33 KB (0%)
packages/react/dist/browser.umd.js 99.67 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5297 November 14, 2024 19:43 Inactive
@randall-krauskopf randall-krauskopf marked this pull request as ready for review November 14, 2024 21:10
@randall-krauskopf randall-krauskopf requested review from a team as code owners November 14, 2024 21:10
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 346ad0c Nov 15, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the pagination-snapshot branch November 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randall-krauskopf @jonrohan