Polish custom GH desktop icons

[ashygee]

The Desktop team recently updated the octicons in the app and we need to polish so that they follow the octicons design guidelines.

Icons needed

• arrow-small-up
• arrow-small-down
• stash
• force-push
• co-author

Current design

Co-author

Force push

Stash

Small arrows

[edokoa]

Do we aim to keep the different size viewports, or will we work with fixed size (16x) icons and then decide whether we want to crop them or not?

This also opens the question of being able to crop whitespace in icons.

[edokoa]

For force-push we had this variant that we didn't include in the set. It also depends on how the push icon used in the app looks
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=5395%3A4487

[edokoa]

Regarding the add user icon, we'll be working on modifiers after EOY, but I'd consider this, taking into account how the user and group look in the set: https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=5395%3A4619

This also opens the question of custom size icons in the app, and the need to make them consistent so it matches .com and works with the rest of the Octicons set.

[edokoa]

About the arrows. I don't have the exact size it has to display into, but those are the fold arrows with and without a line. The decision of making the arrowhead solid was an stylistic decision that depends on the size of the arrow more than the function it serves, as line arrows are difficult to render below certain size.
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=5395%3A4647
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=5395%3A4723

[edokoa]

About the stash icon, if we want to keep the same methaphor it'd have to be like this. I've been trying to fit 3 layers in the space we have but they become blurry when scaling down to 16px
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=5395%3A10199

[ashygee]

Hi! We're going to add the person-plus (add co-author) icon t octicons but would like an update on the rest of the icons. cc @ampinsk

[github-actions]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.