-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #1292
Conversation
🦋 Changeset detectedLatest commit: 93f9814 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/8WyNMsGKURitbw4m5ZpJMLQiYaUt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up, @dgreif! Let's bump @primer/primitives
to latest
in this PR as well 👍
@VanAnderson is going to run a quick test of |
This snapshot diff looks odd to me: https://github.com/primer/components/runs/2806099805#step:7:2042 I think this is happening because |
Bumping all the base level dependencies (not docs) in hopes of clearing a bunch of dependabot PRs
jsdom
as our default for now, but we could usenode
as the default and only usejsdom
for the files that actually need it. Here's the release notes for those interested: https://jestjs.io/blog/2021/05/25/jest-27react-docgen-typescript
that prevents us from going all the way to the latest ts version. Looks like it is fixed and should be released soon: TypeError: (tag.text || "").trim is not a function styleguidist/react-docgen-typescript#356styled-components
because it causes all of our snapshots to fail. It looks like v5 has some major performance improvements, so we should definitely consider updating soon.