Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog is not modal when v-if used #94

Closed
fairking opened this issue Nov 26, 2019 · 1 comment
Closed

Dialog is not modal when v-if used #94

fairking opened this issue Nov 26, 2019 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@fairking
Copy link

fairking commented Nov 26, 2019

It is not a big problem for me at the moment but I think it might be needed in the future.
Because sometimes I would like not to render dialogs if they are not used at all so I use v-if.
What I found is if I use <Dialog v-if="dialogActive" :visible.sync="dialogActive" :modal="true" /> the dialog stops being modal.
Maybe I am wrong and the :visible is actually the same as v-if.
Please let me know what do you think about it or if you need more details.

@cagataycivici cagataycivici self-assigned this Dec 9, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 9, 2019
@cagataycivici cagataycivici added this to the 1.0.0-rc.1 milestone Dec 9, 2019
@fairking
Copy link
Author

fairking commented Dec 9, 2019

Thanks @cagataycivici . Very appreciate your great job. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants