Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Variant "link" is not assignable #6756

Closed
carloeusebi opened this issue Nov 9, 2024 · 2 comments
Closed

Button: Variant "link" is not assignable #6756

carloeusebi opened this issue Nov 9, 2024 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@carloeusebi
Copy link

carloeusebi commented Nov 9, 2024

Describe the bug

image

Component works just fine, I think the button/index.d.ts:179 file is not updated correctly:

     * Specifies the variant of the component.
     * @defaultValue undefined
     */
    variant?: 'outlined' | 'text' | undefined;

I repeat, button works as explained in documentation:
link to documentation: https://primevue.org/button/#link

Reproducer

https://stackblitz.com/edit/primevue-4-ts-vite-issue-template-jyn1kh?file=src%2FApp.vue

PrimeVue version

4.2.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@carloeusebi carloeusebi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 9, 2024
@25Das
Copy link

25Das commented Nov 9, 2024

<Button label="Button" link /> works too and don't raise any type error.
I don't know which, docs or component file, are outdated, both ways work besides type error on variant property.

@mitchgibson
Copy link

Is this a bug or does the documentation need an update?

https://primevue.org/button/#link

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 14, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.2 milestone Nov 14, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants