-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes are installed by the wrong package #5898
Comments
Hi @mertsincan, In version Could you please clarify where we should import Currently, we have to use the following workaround: // @ts-expect-error Remove once types are fixed
import { $dt } from "@primeuix/styled"; Could you please address the type definition so we don't need to use Thank you! |
Additionally, we need to import types from |
Hi @mcmimik, Thanks a lot for your testing and report! Could you please create a separate ticket for it? I'll work on it in the next release. Best Regards, |
Also, import Aura from |
Is its type definition? |
@primeuix/styled is the core API. So, you shouldn't need this. You need always use @primevue/themes and it uses this core API and exports it via @primevue/themes. |
Vite can't find it: This is the import:
This is the error message on dev build:
I can't see it in the node_modules either. |
Thanks a lot for the update, @cwillinx! But, this structure has already changed. Please see; https://primevue.org/theming/styled/ Custom theme example; https://github.com/primefaces/primevue/blob/master/apps/showcase/themes/app-theme.js A starter with vite; https://github.com/primefaces/primevue-examples/tree/main/vite-quickstart |
Ok, now I understand, I have to install it as a separate npm package. Doing that, it's working fine, I just realized this change |
Sure, here it is: #5910 |
When @primevue/core is installed, the @primevue/theme package is also installed. This is a mistake and unstyled mode may also cause problems. That's why themes should always be included in the project separately from the @primevue/themes package.
The text was updated successfully, but these errors were encountered: