Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: The initial value of expendedRow is not reflected and the value change is not detected. #5086

Closed
bdh92123 opened this issue Jan 15, 2024 · 2 comments
Assignees

Comments

@bdh92123
Copy link
Contributor

Describe the bug

If the expandedRow props of a DataTable is specified as an initial value along with some data, it is not reflected.

  • It seems to operate by watching expandedRows prop, and the immediate property appears to be false.

If only part of the data specified as expandedRows is modified externally, it will not be reflected.

  • Due to the same problem as above, the deep property seems to be false when watching expandedRows. It seems problematic that the entire value must be replaced to be reflected.

Reproducer

https://codesandbox.io/s/primevue-demo-forked-ym4crg

PrimeVue version

3.45.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

Chrome

Steps to reproduce the behavior

Initial values not being reflected

  1. Specifies an initial value for expandedRows along with some data.
  2. The specified row is not expanded.

Partial modifications to the expandedRows value are not reflected

  1. Add the dataKey of a specific row as true in the expandedRows value.
  2. The specified row is not expanded.

Expected behavior

  1. It should appear expanded with the initial data.
  2. Some modifications to the expandedRows value must also be reflected.
@bdh92123 bdh92123 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! I'll check it before the next version is released.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2024
@mertsincan mertsincan added this to the 3.47.0 milestone Jan 15, 2024
@mertsincan mertsincan self-assigned this Jan 15, 2024
@mertsincan
Copy link
Member

Hi,

I think this issue has already been fixed in #5057

Best Regards,

@mertsincan mertsincan removed this from the 3.47.0 milestone Jan 22, 2024
@mertsincan mertsincan removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants