Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: scrollHeight flex not working #5032

Closed
AcidRaZor opened this issue Jan 4, 2024 · 3 comments
Closed

DataTable: scrollHeight flex not working #5032

AcidRaZor opened this issue Jan 4, 2024 · 3 comments
Assignees
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team

Comments

@AcidRaZor
Copy link

Describe the bug

When using scrollable with virtualScrollerOptions, I'm unable to set the scollHeight to be that of the view port size. I found an issue from 2015 that was "fixed" based on a forum suggestion (issue #30) but I can't figure out how to set height to 100%

In the API documentation, scrollHeight is expected to be null, px or the keyword flex to make it dynamic.

flex doesn't work

this may be related to change:

ac0aad6

:style="scrollHeight !== 'flex' ? { height: scrollHeight } : undefined"
:scrollHeight="scrollHeight !== 'flex' ? undefined : '100%'"

style appears to be set to undefined, yet the next line shows what I think should be happening, where it's set to 100%

Reproducer

/

PrimeVue version

3.45.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Expected behavior

set scrollHeight to 100%

@AcidRaZor AcidRaZor added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 4, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2024
@mertsincan mertsincan added this to the 3.47.0 milestone Jan 11, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! We'll check before the next version release

@mertsincan mertsincan self-assigned this Jan 16, 2024
@mertsincan
Copy link
Member

Unfortunately, I couldn't replicate it. Please try; https://stackblitz.com/edit/we8uab?file=src%2FApp.vue

For now, closed. If the problem persists, please reopen this ticket with a sample stackblitz link.
Best Regards,

@mertsincan mertsincan removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 22, 2024
@mertsincan mertsincan removed this from the 3.47.0 milestone Jan 22, 2024
@mertsincan mertsincan added the Resolution: Cannot Replicate Issue could not be replicated by Core Team label Jan 22, 2024
Copy link

We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
None yet
Development

No branches or pull requests

3 participants