Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Closing fullscreen image (from preview) breaks scrolling #4401

Closed
Gikkman opened this issue Sep 6, 2023 · 0 comments · Fixed by #4402
Closed

Image: Closing fullscreen image (from preview) breaks scrolling #4401

Gikkman opened this issue Sep 6, 2023 · 0 comments · Fixed by #4402
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Gikkman
Copy link

Gikkman commented Sep 6, 2023

Describe the bug

I'm using an Image on my site with the preview property. When I clicked the image (to show it in fullscreen), and then close the fullscreen mode (by clicking outside the image), I cannot scroll anymore on the page. If you close the fullscreen mode by clicking the X in the top-right, scrolling is preserved.

You can see the same effect on your Component overview page for Image: https://primevue.org/image/#preview

Click the preview, then click on the gray background mask to close the fullscreen mode, and now scrolling doesn't work.

Reproducer

https://primevue.org/image/#preview

PrimeVue version

3.32.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chome, Firefox (On a M1 Mac)

Steps to reproduce the behavior

  1. Go to https://primevue.org/image/#preview
  2. Click the Preview image (to bring it up in fullscreen)
  3. Click the background mask to close the fullscreen
  4. Try to scroll

Expected behavior

I expect scrolling to work irregardless of how we close the preview.

@Gikkman Gikkman added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 6, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 7, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.34.1 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants