Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Icon slots issues #4366

Closed
Magiczne opened this issue Aug 31, 2023 · 0 comments
Closed

DataTable: Icon slots issues #4366

Magiczne opened this issue Aug 31, 2023 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Magiczne
Copy link
Contributor

Describe the bug

Similar to #4264, #4301, #4302, #4303, #4304, #4305, #4364

It is related to #3921 as well, because it should be way to modify paginator dropdown icons as well.
As in #4364 I'm not including reproducer, becuse most of things are just missing.

  1. Following DataTable slots:
paginatorfirstpagelinkicon
paginatorprevpagelinkicon
paginatornextpagelinkicon
paginatorlastpagelinkicon

are not exposing .p-paginator-icon class in the slot scope - it should be exposed, as the default SVG icons use it.

  1. There is no way to override following icons using slots:
Checkbox icons in the selector columns
Checkbox in the header
Filtering icon
Sorting icons (ascending, descending, default)
  1. Slot rowgrouptogglericon is not exposing p-row-toggler-icon which is applied by default to the icon

Reproducer

PrimeVue version

3.32.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 31, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 1, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.33.2 milestone Sep 5, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants