Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Conflict between DataTable with expander and Panel #4335

Closed
kubiksk8ter opened this issue Aug 28, 2023 · 1 comment
Closed

DataTable: Conflict between DataTable with expander and Panel #4335

kubiksk8ter opened this issue Aug 28, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@kubiksk8ter
Copy link

Describe the bug

When DataTable with expandable rows is inserted into default slot of Panel component and row is expanded, then DataTable mount again every expanded row component.
Even in row collapse, DataTable mount every expanded row component again.
Even in Panel collapse, DataTable mount every expanded row component again.

Reproducer

https://codesandbox.io/p/sandbox/cranky-tesla-xy6qh2?welcome=true

PrimeVue version

3.32.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Click on row to expand. Click another row to expand. Now you see, both row are mounted again.

Expected behavior

Only requiring row should be mounted and on row collapse no row should be mounted.

@kubiksk8ter kubiksk8ter added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 28, 2023
@mertsincan
Copy link
Member

Hi,

I made some changes related to the expandedRows feature. #4977
Also, you can remove v-model: (two-way binding) from expandedRows. This type of two-way binding will always re-render the component.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants