Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog, Sidebar: Not working if v-model:visible is changed quickly #3940

Closed
Hiroki-Tamaru opened this issue May 10, 2023 · 1 comment · Fixed by #3943
Closed

Dialog, Sidebar: Not working if v-model:visible is changed quickly #3940

Hiroki-Tamaru opened this issue May 10, 2023 · 1 comment · Fixed by #3943
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Hiroki-Tamaru
Copy link

Describe the bug

  1. Use Dialog or Sidebar.
  2. Change the v-model:visible parameter very frequently (like 10ms) several times.
  3. The component does not appear and the script stops working.

The threshold interval time seems to depend on the amount of contents of the Dialog/Sidebar.

Reproducer

https://codesandbox.io/s/determined-easley-hg74jm

PrimeVue version

3.28.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Confirm that the interval (ms) value is 1000.
  2. Click the "Start" button.
  3. Confirm that the Dialog component appears and hides periodically.
  4. Reload the demo.
  5. Enter "10" in the interval value input.
  6. Click the "Start" button.
  7. Confirm that the Dialog component does not appear.

Expected behavior

The Dialog/Sidebar component should be displayed and hidden even if it is done very quickly.

@Hiroki-Tamaru Hiroki-Tamaru added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2023
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 10, 2023
@bahadirsofuoglu bahadirsofuoglu self-assigned this May 10, 2023
@bahadirsofuoglu bahadirsofuoglu modified the milestones: 3.29.0, 3.x May 10, 2023
@Zebnastien
Copy link

I can confirm this bug with latest Primevue release (3.30.2). Very easy to reproduce.
Just put a Sidebar with :modal="false" and a Button to open the sidebar.

Quickly click button -> Error repeatedly in console
image

Very annoying as it breaks the interactivity of the page and requires a refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants