Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog not reopening #1675

Closed
ollyrowe opened this issue Oct 15, 2021 · 1 comment
Closed

ConfirmDialog not reopening #1675

ollyrowe opened this issue Oct 15, 2021 · 1 comment

Comments

@ollyrowe
Copy link

ollyrowe commented Oct 15, 2021

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Description
I've been working with the ConfirmationService / ConfirmDialog components using the this.$confirm.require(...) API, and I've come across an issue with closing and re-opening dialogs. After require(...) is called for the first time, the confirmation dialog appears as expected (correct behaviour, etc.) however after closing the dialog via the close-icon at the top right of the dialog, the dialog closes (as expected), however subsequent require(...) calls do not re-open the dialog.

After looking into the source behind the ConfirmDialog component, I can see that a closeDialog() method is called upon clicking the Dialog component. This method contains an if statement which basically turns off the subscribers to the event bus if the close-icon button is the target - this is the code which is causing the issue I'm experiencing. Is this intended behaviour?

Environment

  • Vue version: 2.6.12
  • PrimeVue version: 2.5.1
@ollyrowe ollyrowe changed the title Confirmation dialog not reopening ConfirmDialog not reopening Oct 18, 2021
@cagataycivici cagataycivici added this to the 2.6.1 milestone Oct 25, 2021
@tugcekucukoglu tugcekucukoglu removed this from the 2.6.1 milestone Nov 24, 2021
@tugcekucukoglu tugcekucukoglu removed their assignment Nov 24, 2021
@tugcekucukoglu
Copy link
Member

Please track that issue #1746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants