Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeedDial :hideOnClickOutside="false" is not working #1545

Closed
thomaswan opened this issue Sep 15, 2021 · 0 comments
Closed

SpeedDial :hideOnClickOutside="false" is not working #1545

thomaswan opened this issue Sep 15, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@thomaswan
Copy link
Contributor

If you have a PrimeVue PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 1 business hour.

If you do not have a PrimeVue PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~1-4 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
https://codesandbox.io/s/flamboyant-cohen-udvvm

Current behavior

SpeedDial with props :hideOnClickOutside="false"
click outside would toggle close event

Expected behavior

SpeedDial with props :hideOnClickOutside="false"
click outside would NOT toggle close event

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

this.bindDocumentClickListener() is called in beforeMount without case checking. update code to check props hideOnClickOutside before bind listener.

Please tell us about your environment:

  • Vue version: 3.X
  • PrimeVue version: 3.6.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 4, 2021
@tugcekucukoglu tugcekucukoglu added this to the 3.7.3 milestone Oct 4, 2021
@tugcekucukoglu tugcekucukoglu self-assigned this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants