Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Filter Menu error #1133

Closed
nclemeur opened this issue Mar 29, 2021 · 3 comments
Closed

DataTable: Filter Menu error #1133

nclemeur opened this issue Mar 29, 2021 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@nclemeur
Copy link

nclemeur commented Mar 29, 2021

This problem is reproducible in https://www.primefaces.org/primevue/showcase/#/datatable/filter
You just need to open a column menu filter, before opening another one without clicking anything else in between...

I believe the problems is because the method onOverlayHide in ColumnFilter is not called in the first column menu and therefore it remains wrongly subscribed to the overlay-click event although the overlay has been removed. Maybe if should be called from the outsideClickListener?

PrimeVUE.Mozilla.Firefox.2021-03-29.22-50-25.mp4
Uncaught TypeError: e.overlay is null
    onOverlayEnter https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    t https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    emit https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    onOverlayClick https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    10 https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    je https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Ce https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    n https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Wi https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    qi https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Ki https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    L https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    k https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    update https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    n https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    je https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    at https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    promise callback*$e https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Ke https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    h https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    x https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    scheduler https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    h https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    x https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    E https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    set https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    show https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    onClick https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    11 https://www.primefaces.org/primevue/showcase/js/app.a07d6a6f.js:1
    je https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Ce https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    n https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Wi https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    qi https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    Ki https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    L https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    k https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    update https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    n https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    c https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    P https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    j https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    E https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    T https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    O https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    update https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    n https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    c https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    P https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    j https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    E https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    T https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    L https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    k https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    T https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    O https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
    y https://www.primefaces.org/primevue/showcase/js/chunk-vendors.ff498df3.js:155
@simkusT
Copy link

simkusT commented Apr 4, 2021

Uncaught TypeError: Cannot read property 'contains' of null

e.overlay.contains(t.target) && (e.selfClick = !0)

this.overlay is null <--

PrimeVUE.mp4

@nclemeur
Copy link
Author

I think this issue (along with #1076) is a good candidate for milestone 3.4.0. It should at the very minimum be triaged as a bug

@cagataycivici cagataycivici self-assigned this Apr 15, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 15, 2021
@cagataycivici cagataycivici added this to the 3.4.0 milestone Apr 15, 2021
@cagataycivici
Copy link
Member

Fixed via;

#1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants