Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog component] Warning: Accessing element.ref was removed in React 19 #7510

Closed
Pedja013 opened this issue Dec 16, 2024 · 3 comments · Fixed by #7539
Closed

[Dialog component] Warning: Accessing element.ref was removed in React 19 #7510

Pedja013 opened this issue Dec 16, 2024 · 3 comments · Fixed by #7539
Assignees
@melloware
Labels
React 18/19 Issue or pull request is *only* related to React 18/19
Milestone
10.9.0

Comments

@Pedja013
Copy link

Describe the bug

After upgrading to react v19, when opening dialog error is visible in console

Reproducer

No response

System Information

System: Windows 11
primereact => 10.6.6
react => 19.0.0

Steps to reproduce the behavior

When opening dialog which is using primereact dialog component error is visible in console.

Expected behavior

No response
@Pedja013 Pedja013 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 16, 2024
@melloware melloware added React 18/19 Issue or pull request is *only* related to React 18/19 and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@sja-cslab
Copy link
Contributor

sja-cslab commented Dec 17, 2024 •
edited
Loading

PrimeReact is not yet optimised for React 19 and is using a lot of manual refs. The React 19 implementation changed a lot so this may take a while.

@simonwidjaja
Copy link

same here. Is there a rough roadmap for supporting react 19?
so far my current project with primereact works just perfect except the ref error... keep up the great work!

@melloware melloware mentioned this issue Dec 23, 2024
Closed
@sja-cslab
Copy link
Contributor

sja-cslab commented Dec 23, 2024 •
edited
Loading

PrimeTek currently working on a PrimeReact-Rework. I cannot say for sure but I guess React 19 will be supported there.
I haven't seen any public roadmap but in Discord they said Q1 of 2025 a beta Version will be available

@melloware melloware mentioned this issue Jan 1, 2025
Merged
@melloware melloware added this to the 10.8.6 milestone Jan 1, 2025
@melloware melloware self-assigned this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
React 18/19 Issue or pull request is *only* related to React 18/19
Projects
None yet
Milestone
10.9.0
Development

Successfully merging a pull request may close this issue.

Fix #7403: FocusTrap in React19 must not access element.ref melloware/primereact
4 participants
@simonwidjaja @melloware @Pedja013 @sja-cslab