Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputText: props.invalid does not work correctly in Passthrough (Tailwind) #7275

Closed
selcukkutuk opened this issue Sep 30, 2024 · 4 comments
Closed
Labels
Component: Tailwind Tailwind specific issue
Milestone

Comments

@selcukkutuk
Copy link

selcukkutuk commented Sep 30, 2024

Describe the bug

When using InputText with Tailwind pt, setting the value of props.invalid to true does not add the p-invalid value or tw error border classes to the css class list. When I try it with InputMask, the same situation applies to that as well.

Reproducer

https://stackblitz.com/edit/zec5xp?file=src%2FApp.jsx

System Information

"react": "^18.3.1",
"primereact": "^10.8.3"

Steps to reproduce the behavior

  1. Add InputText component
  2. Set invalid prop to true

Expected behavior

When the invalid prop is set to true, the p-invalid css class or tw error border classes should be added to the component's class list.

@selcukkutuk selcukkutuk added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 30, 2024
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 30, 2024
@melloware
Copy link
Member

cc @gcko

@jeffpapp
Copy link

This should be fixed in #7226. I opened #7195 for InputMask issue and the invalid check was also added for the default Tailwind passthrough for InputText as well.

@melloware
Copy link
Member

Thanks @jeffpapp !

@melloware melloware added this to the 10.8.4 milestone Oct 1, 2024
@selcukkutuk
Copy link
Author

selcukkutuk commented Oct 1, 2024

Thank you for quick answer. Good luck. @melloware @jeffpapp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Development

No branches or pull requests

3 participants