Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: rowReorder not displaying "ghost" row when dragging #6548

Closed
romanzhukov23 opened this issue May 2, 2024 · 13 comments · Fixed by #6581
Closed

DataTable: rowReorder not displaying "ghost" row when dragging #6548

romanzhukov23 opened this issue May 2, 2024 · 13 comments · Fixed by #6581
Assignees
@KirilCycle
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.6

Comments

@romanzhukov23
Copy link

romanzhukov23 commented May 2, 2024 •
edited
Loading

Describe the bug

When I replace rowReorderIcon, the row stops being draggable, but only the icon starts to be draggable. What can I do with this to make the string draggable?

Reproducer

https://stackblitz.com/edit/vitejs-vite-ixav5s?file=src%2FApp.tsx

PrimeReact version

10.5.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Try to drag'n'drop any row

Expected behavior

No response
@romanzhukov23 romanzhukov23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@melloware
Copy link
Member

@romanzhukov23 your stackblitz is working fine for me I can reorder the rows using 10.6.4: https://stackblitz.com/edit/vitejs-vite-rrnm2t?file=src%2FApp.tsx

@melloware melloware added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days.

@melloware
Copy link
Member

Also for me the ROW is never draggable? Only the ICON is draggable. Same as the showcase: https://primereact.org/datatable/#reorder

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@romanzhukov23
Copy link
Author

@romanzhukov23 your stackblitz is working fine for me I can reorder the rows using 10.6.4: https://stackblitz.com/edit/vitejs-vite-rrnm2t?file=src%2FApp.tsx

I mean, when dragging, only the icon follows the cursor, but not the entire line, as in the default version

@romanzhukov23
Copy link
Author

default icon.webm
not default icon.webm
maybe this help to understand problem

@melloware
Copy link
Member

Oh I see one sec That makes more sense.

@melloware melloware reopened this May 2, 2024
@melloware melloware added question Issue contains a question about the use of PrimeReact components or the products it supports and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels May 2, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@melloware melloware changed the title DataTable: rowReorderIcon DataTable: rowReorderIcon not displaying "ghost" row when dragging May 2, 2024
@melloware melloware changed the title DataTable: rowReorderIcon not displaying "ghost" row when dragging DataTable: rowReorder not displaying "ghost" row when dragging May 2, 2024
@romanzhukov23
Copy link
Author

Oh I see one sec That makes more sense.

so can I do anything with this problem?)

@melloware
Copy link
Member

I think it needs to be investigated why its happening with a custom icon... could be a bug.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed question Issue contains a question about the use of PrimeReact components or the products it supports labels May 2, 2024
@KirilCycle
Copy link
Contributor

Hmmmm, i think i know what is going on here, let me fix it

@romanzhukov23
Copy link
Author

Hmmmm, i think i know what is going on here, let me fix it

Ill be very grateful

@KirilCycle KirilCycle mentioned this issue May 6, 2024
Merged
@melloware melloware added this to the 10.7.0 milestone May 7, 2024
@romanzhukov23
Copy link
Author

https://stackblitz.com/edit/vitejs-vite-ydodxm?file=src%2FApp.tsx
Try to drag. Bug isn't fixed

@romanzhukov23 romanzhukov23 mentioned this issue May 27, 2024
Closed
@KirilCycle
Copy link
Contributor

https://stackblitz.com/edit/vitejs-vite-ydodxm?file=src%2FApp.tsx Try to drag. Bug isn't fixed

iconProps not IconProps

@melloware
Copy link
Member

@romanzhukov23 yep here is a fixed version working fine: https://stackblitz.com/edit/vitejs-vite-fsx4n2?file=src%2FApp.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirilCycle KirilCycle

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.6
Development

Successfully merging a pull request may close this issue.

Fix: Row reorder icon image wont brake drag 'ghost' KirilCycle/primereact
3 participants
@melloware @romanzhukov23 @KirilCycle