Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation for Accordion #182

Closed
joshdanhall opened this issue Nov 13, 2017 · 3 comments
Closed

Animation for Accordion #182

joshdanhall opened this issue Nov 13, 2017 · 3 comments
Assignees
@Merve7
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
1.3.0-RC1

Comments

@joshdanhall
Copy link

Primereact are great components. Some UI sugar I would like is to make the opening/closing of panels to be animated. They are quite jarring otherwise. I'm thinking Accordian, TabView & Fieldset.
@cagataycivici cagataycivici added this to the 1.2.1 milestone Nov 17, 2017
@cagataycivici
Copy link
Member

Agree, we've done it for Panel on 1.2.0 to begin with and will do for rest as well just like PrimeNG or PrimeFaces has.

@Merve7 Merve7 closed this as completed in 13b385a Nov 22, 2017
@joshdanhall
Copy link
Author

joshdanhall commented Nov 22, 2017 •
edited
Loading

Looked at the commit and it seems to only address Accordion. Is there a plan to apply to TabView and Fieldset (Fieldset is actually the main one I would like)?

@cagataycivici
Copy link
Member

Fieldset has it as well, PrimeNG and PrimeFaces tabview does not have animation so we left it our for now.

@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Nov 28, 2017
@cagataycivici cagataycivici changed the title Animations for panels Animation for Accordion Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merve7 Merve7

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
1.3.0-RC1
Development

No branches or pull requests
3 participants
@cagataycivici @joshdanhall @Merve7