Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown: Long headings broken (also unstable) #3169

Closed
SimenB opened this issue Nov 7, 2017 · 2 comments
Closed

Markdown: Long headings broken (also unstable) #3169

SimenB opened this issue Nov 7, 2017 · 2 comments
Assignees
@ikatyang
Labels
lang:markdown Issues affecting Markdown locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! type:bug Issues identifying ugly output, or a defect in the program
Milestone
1.8.1

Comments

@SimenB
Copy link
Contributor

SimenB commented Nov 7, 2017

Prettier 1.8.0
Playground link

--parser markdown

Input:

### `reporters` [array<moduleName | [moduleName, options]>]

### `reporters` [array<moduleName | [moduleName,
options]>]

Output:

### `reporters` [array<moduleName | [moduleName,
options]>]

### `reporters` [array<moduleName | [moduleName,

options]>]

Expected behavior:
No change on input
@SimenB SimenB mentioned this issue Nov 7, 2017
Merged
@SimenB SimenB changed the title Markdown: Long headings broken Markdown: Long headings broken (also unstable) Nov 7, 2017
@SimenB
Copy link
Contributor Author

SimenB commented Nov 7, 2017

This is extra weird as the heading has a width of 60, so it shouldn't be broken anyways

@ikatyang ikatyang added lang:markdown Issues affecting Markdown priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! type:bug Issues identifying ugly output, or a defect in the program labels Nov 7, 2017
@azz azz added this to the 1.8.1 milestone Nov 7, 2017
@SimenB SimenB mentioned this issue Nov 7, 2017
Merged
@ikatyang ikatyang mentioned this issue Nov 7, 2017
Merged
@ikatyang ikatyang self-assigned this Nov 7, 2017
@azz azz closed this as completed in #3177 Nov 7, 2017
@azz
Copy link
Member

azz commented Nov 7, 2017

This has been fixed in 1.8.1.

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ikatyang ikatyang

Labels
lang:markdown Issues affecting Markdown locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
1.8.1
Development

No branches or pull requests
3 participants
@azz @SimenB @ikatyang