Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pretender importable in node #268

Open
samselikoff opened this issue Sep 10, 2019 · 3 comments
Open

Make Pretender importable in node #268

samselikoff opened this issue Sep 10, 2019 · 3 comments

Comments

@samselikoff
Copy link
Contributor

samselikoff commented Sep 10, 2019

👋 Hey all!

As we're getting Mirage to work in different environments, Pretender not being importable is causing us some headaches.

I know that having Pretender work in node is one thing, and that increases the scope of this project and requires more resources for maintenance, but is having it importable something that we could consider committing to?

If so we can take on the work & add some test coverage. That way Mirage can always "just import" Pretender and then decide at run-time whether to instantiate it.

Here's an older issue for reference: #192

cc @trek @stefanpenner

@stefanpenner
Copy link
Contributor

@samselikoff sounds good, let's just ensure it is also tested so it does not regress.

@samselikoff
Copy link
Contributor Author

sweet, we're going to work on this today

@samselikoff
Copy link
Contributor Author

@stefanpenner any chance you could shed light on iife-wrapper? First time I'm seeing this (though I'm new to rollup & configuring builds). Seems like the self/iife there is what's causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants