Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and enforce bidder currency requirement #3746

Open
bretg opened this issue Jun 11, 2024 · 4 comments
Open

Collect and enforce bidder currency requirement #3746

bretg opened this issue Jun 11, 2024 · 4 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jun 11, 2024

Our advice for bid adapters related to currency is at https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#currency .

This works fine as long as the bidder has their own adapter, but doesn't work if they're an alias of the 'generic' bidder.

I propose adding a currency-accepted setting to the YAML:

adapters:
  generic:
    endpoint: https://
    aliases:
      bidderA:
        enabled: true
        endpoint: ...
        meta-info:
          currency-accepted:
            - USD
            - CAD
          maintainer-email: ...
          site-media-types:
            - banner
          vendor-id: 999999

If the bidder defines currency-accepted and $.cur doesn't intersect, then don't call this bidder/alias. Log a seatnonbid code 205 "Request blocked - General"

@bretg
Copy link
Contributor Author

bretg commented Jun 14, 2024

We should make a new, more specific seatnonbid code on this.

@bretg
Copy link
Contributor Author

bretg commented Aug 14, 2024

Opened the IAB PR. If it's approved, then the scenario would be seatnonbid 205 instead of the generic 200.

@Compile-Ninja Compile-Ninja self-assigned this Aug 30, 2024
@Compile-Ninja
Copy link

Java version prebid/prebid-server-java#3416

@bretg
Copy link
Contributor Author

bretg commented Sep 19, 2024

released with PBS-Java 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants