From 5f816b4cff372a087a1073f7fb0cef1ce8080315 Mon Sep 17 00:00:00 2001
From: Marvin Hagemeister <hello@marvinh.dev>
Date: Thu, 7 Dec 2023 22:56:55 +0100
Subject: [PATCH 1/2] fix: incorrect oninput + onsubmit type

---
 src/jsx.d.ts       | 18 ++++++++++++++----
 test/ts/preact.tsx |  9 ++++++++-
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/src/jsx.d.ts b/src/jsx.d.ts
index 1ebd557c3b..00fab95e37 100644
--- a/src/jsx.d.ts
+++ b/src/jsx.d.ts
@@ -1441,6 +1441,10 @@ export namespace JSXInternal {
 		Target,
 		FocusEvent
 	>;
+	export type TargetedInputEvent<Target extends EventTarget> = TargetedEvent<
+		Target,
+		InputEvent
+	>;
 	export type TargetedKeyboardEvent<Target extends EventTarget> = TargetedEvent<
 		Target,
 		KeyboardEvent
@@ -1495,6 +1499,9 @@ export namespace JSXInternal {
 	export type GenericEventHandler<Target extends EventTarget> = EventHandler<
 		TargetedEvent<Target>
 	>;
+	export type InputEventHandler<Target extends EventTarget> = EventHandler<
+		TargetedInputEvent<Target>
+	>;
 	export type KeyboardEventHandler<Target extends EventTarget> = EventHandler<
 		TargetedKeyboardEvent<Target>
 	>;
@@ -1504,6 +1511,9 @@ export namespace JSXInternal {
 	export type PointerEventHandler<Target extends EventTarget> = EventHandler<
 		TargetedPointerEvent<Target>
 	>;
+	export type SubmitEventHandler<Target extends EventTarget> = EventHandler<
+		TargetedSubmitEvent<Target>
+	>;
 	export type TouchEventHandler<Target extends EventTarget> = EventHandler<
 		TargetedTouchEvent<Target>
 	>;
@@ -1563,14 +1573,14 @@ export namespace JSXInternal {
 		// Form Events
 		onChange?: GenericEventHandler<Target> | undefined;
 		onChangeCapture?: GenericEventHandler<Target> | undefined;
-		onInput?: GenericEventHandler<Target> | undefined;
-		onInputCapture?: GenericEventHandler<Target> | undefined;
+		onInput?: InputEventHandler<Target> | undefined;
+		onInputCapture?: InputEventHandler<Target> | undefined;
 		onBeforeInput?: GenericEventHandler<Target> | undefined;
 		onBeforeInputCapture?: GenericEventHandler<Target> | undefined;
 		onSearch?: GenericEventHandler<Target> | undefined;
 		onSearchCapture?: GenericEventHandler<Target> | undefined;
-		onSubmit?: TargetedSubmitEvent<Target> | undefined;
-		onSubmitCapture?: TargetedSubmitEvent<Target> | undefined;
+		onSubmit?: SubmitEventHandler<Target> | undefined;
+		onSubmitCapture?: SubmitEventHandler<Target> | undefined;
 		onInvalid?: GenericEventHandler<Target> | undefined;
 		onInvalidCapture?: GenericEventHandler<Target> | undefined;
 		onReset?: GenericEventHandler<Target> | undefined;
diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
index 757cf3f655..5e2a1e4ea0 100644
--- a/test/ts/preact.tsx
+++ b/test/ts/preact.tsx
@@ -362,7 +362,14 @@ createElement(RefComponentTest, { ref: functionRef }, 'hi');
 h(RefComponentTest, { ref: functionRef }, 'hi');
 
 // Should accept onInput
-const onInput = (e: h.JSX.TargetedEvent<HTMLInputElement>) => {};
+const onInput = (e: h.JSX.TargetedInputEvent<HTMLInputElement>) => {};
 <input onInput={onInput} />;
+<input onInput={e => e.currentTarget.value} />;
 createElement('input', { onInput: onInput });
 h('input', { onInput: onInput });
+
+// Should accept onSubmit
+const onSubmit = (e: h.JSX.TargetedSubmitEvent<HTMLFormElement>) => {};
+<form onSubmit={e => e.currentTarget.elements} />;
+createElement('form', { onSubmit: onSubmit });
+h('form', { onSubmit: onSubmit });

From 0c7fd521c4bb0cbab9217494acd97411d96aff8b Mon Sep 17 00:00:00 2001
From: Marvin Hagemeister <hello@marvinh.dev>
Date: Thu, 7 Dec 2023 23:14:02 +0100
Subject: [PATCH 2/2] fix: onBeforeInput event type

---
 src/jsx.d.ts       | 4 ++--
 test/ts/preact.tsx | 7 ++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/jsx.d.ts b/src/jsx.d.ts
index 00fab95e37..a87297d97c 100644
--- a/src/jsx.d.ts
+++ b/src/jsx.d.ts
@@ -1575,8 +1575,8 @@ export namespace JSXInternal {
 		onChangeCapture?: GenericEventHandler<Target> | undefined;
 		onInput?: InputEventHandler<Target> | undefined;
 		onInputCapture?: InputEventHandler<Target> | undefined;
-		onBeforeInput?: GenericEventHandler<Target> | undefined;
-		onBeforeInputCapture?: GenericEventHandler<Target> | undefined;
+		onBeforeInput?: InputEventHandler<Target> | undefined;
+		onBeforeInputCapture?: InputEventHandler<Target> | undefined;
 		onSearch?: GenericEventHandler<Target> | undefined;
 		onSearchCapture?: GenericEventHandler<Target> | undefined;
 		onSubmit?: SubmitEventHandler<Target> | undefined;
diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
index 5e2a1e4ea0..bbc905d541 100644
--- a/test/ts/preact.tsx
+++ b/test/ts/preact.tsx
@@ -368,7 +368,12 @@ const onInput = (e: h.JSX.TargetedInputEvent<HTMLInputElement>) => {};
 createElement('input', { onInput: onInput });
 h('input', { onInput: onInput });
 
-// Should accept onSubmit
+// Should accept onBeforeInput
+const onBeforeInput = (e: h.JSX.TargetedInputEvent<HTMLInputElement>) => {};
+<input onBeforeInput={e => e.currentTarget.value} />;
+createElement('input', { onBeforeInput: onBeforeInput });
+h('input', { onBeforeInput: onBeforeInput });
+
 const onSubmit = (e: h.JSX.TargetedSubmitEvent<HTMLFormElement>) => {};
 <form onSubmit={e => e.currentTarget.elements} />;
 createElement('form', { onSubmit: onSubmit });