Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to keyed lists break FLIP animations when they occur mid-animation #2637

Open
dead-claudia opened this issue Jul 19, 2020 · 1 comment

Comments

@dead-claudia
Copy link

dead-claudia commented Jul 19, 2020

Reproduction

Flems link

Steps to reproduce

Open sandbox link

Expected Behavior

Animation should be smooth like in this example.

Actual Behavior

Animation is choppy.

Context: Preact is far from the only one affected: https://twitter.com/isiahmeadows1/status/1284726730574315522

Edit: Preact version: 10.4.16

Also relevant: https://github.com/whatwg/html/issues/5742

@developit
Copy link
Member

Hiya! I responded on Twitter, but I'll echo here for folks who come across the issue: this is a DOM (or browser?) issue and there isn't anything Preact can do about it. Inserting a child invalidates its sibling's in-flight animations.

Curious if the browser folks come back with ideas for whether this could be fixed without violating the spec though, since it seems like 99% of the time animations continuing on siblings would be as good as or much better than having them restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants