Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta charset not rendered as expected #275

Closed
aminnairi opened this issue Dec 29, 2022 · 1 comment · Fixed by #308
Closed

Meta charset not rendered as expected #275

aminnairi opened this issue Dec 29, 2022 · 1 comment · Fixed by #308

Comments

@aminnairi
Copy link
Contributor

Describe the bug
When rendering a meta for encoding the page from the server using render, it fails to display the correct attribute casing which should be lowercased for the S letter instead it is uppercased just like it is written in JSX.

To Reproduce
Steps to reproduce the behavior:
Follow instructions for the reproduction repository here.

Expected behavior
It should render the attribute charSet as charset when passing through the render function for the <meta> tag.

Screenshots
None.

Browser (please complete the following information):

  • OS: [e.g. Windows 11]: Arch
  • Browser [e.g. Chrome 108]: Chrome 108

Node (please complete the following information):

  • Platform: [e.g. Node 18]: Node 19.3.0
  • Package Manager [e.g. NPM 8.2.13]: NPM 8.19.2
  • Package Version [e.g. 0.2.1]: 5.2.6

Additional context
None.

@JoviDeCroock
Copy link
Member

Other frameworks don't do this either, it's charset and not char-set which the camelCased variant would imply, I quickly checked how react goes about this and they handle it the same way, they don't touch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants