Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ABlog #86

Closed
damian-krawczyk opened this issue Feb 24, 2021 · 6 comments
Closed

Support for ABlog #86

damian-krawczyk opened this issue Feb 24, 2021 · 6 comments
Labels
enhancement New feature or request needs discussion The approach to resolve this isn't immediately clear, and needs discussion needs info Needs information to reproduce/better understand the issue

Comments

@damian-krawczyk
Copy link

Is your feature request related to a problem? Please describe.
n/a

Describe the solution you'd like
I would like furo theme to support ABlog. It would be good to support even the simplest form:

  • properly formated list of posts on single page
  • properly formated single article

Describe alternatives you've considered
n/a

Additional context
See examples of ABlog for Sphinx in use:

@damian-krawczyk damian-krawczyk added the enhancement New feature or request label Feb 24, 2021
@pradyunsg
Copy link
Owner

Thanks for filing this issue!

You'll need to be more specific about what supporting ABlog would mean/need. What works right now, and what doesn't; why Furo needs to be the one that adds compatibility (rather than the other way round etc).

@pradyunsg pradyunsg added needs discussion The approach to resolve this isn't immediately clear, and needs discussion needs info Needs information to reproduce/better understand the issue labels Feb 26, 2021
@pradyunsg
Copy link
Owner

Closing due to the lack of a response. Feel free to poke this again.

@damian-krawczyk
Copy link
Author

@pradyunsg here I put more details with examples you can check how it works with default theme alabaster, pydata_sphinx_theme and error for furo theme.

@sudopluto
Copy link

looks like (only?) two files to change: https://github.com/sunpy/ablog/search?q=layout.html

@errbufferoverfl
Copy link

@damian-krawczyk I recently made some changes to the furo theme to support ablog, as it currently stands it should work as both a normal Sphinx theme, and an ablog theme and did my best to ensure no breaking changes.

If you plan on testing it locally you'll need to follow the instructions on the workflow to get it to get all the Sass stylesheets and Javascript code working.

Good luck!

@pradyunsg pradyunsg reopened this Sep 24, 2021
Repository owner locked and limited conversation to collaborators Sep 24, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request needs discussion The approach to resolve this isn't immediately clear, and needs discussion needs info Needs information to reproduce/better understand the issue
Projects
None yet
Development

No branches or pull requests

4 participants