Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long song name + artist text overflows into accuracy section on the profile Best Performance page #9360

Open
Tracked by #3504
vruss opened this issue Jun 24, 2020 · 8 comments

Comments

@vruss
Copy link
Contributor

vruss commented Jun 24, 2020

Describe the bug:
Around the 1686x1269 resolution (native 4K monitor) very long song name + artist overflows into the accuracy and weighted section of the performance page. I don't know if mods are also affected similarly.

Reproduce

  1. Go to Vaxei's profile page in-game
  2. Go to Vaxei's Best Performance
  3. Yomi yori

Screenshots or videos showing encountered issue:
osu_2020-06-24_09-08-12

osu!lazer version:
Local build from 2020-06-24

@LastExceed
Copy link
Contributor

what is the desired behavior here? cut-off or word-wrap ?

@frenzibyte
Copy link
Member

frenzibyte commented Jun 24, 2020

image
cut-off by Truncate = true.

@vruss
Copy link
Contributor Author

vruss commented Jun 24, 2020

This 3-mod-play by Whitecat have the same problem

osu_2020-06-24_11-22-49

@frenzibyte
Copy link
Member

Should be fixed similarly.

@LastExceed
Copy link
Contributor

LastExceed commented Jun 24, 2020

I am working on this. it's indeed the same bug

Edit: gave up due to lack of skills. To whoever wants to fix this, you need to prevent this container from overlapping with with this one

@EVAST9919
Copy link
Contributor

The main problem here is that beatmap name is a FillFlowContainer which contains title and artist and can not be trimmed

@frenzibyte
Copy link
Member

frenzibyte commented Jun 28, 2020

As a side note, the web doesn't split the beatmap metadata, just straight up shows one full metadata string with a link to the beatmap itself, maybe consider going that way and easily fix this. (since lazer should match web anyways)

@EVAST9919
Copy link
Contributor

Web version contains 2 separate strings as well, but the container is able to truncate the content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants