Song preview in multiplayer keeps playing in-game if played at the same time the lobby is started

[Pablito3234]

Type

Game behaviour

Bug description

Pretty self descriptive, in a multiplayer lobby, if a song preview is played simultaneously with the start of the lobby, the preview will continue to play even after the game begins. Although the timing window for this issue is narrow, I was able to reliably reproduce it.

Screenshots or videos

osu.lazer.bug.demonstration.mp4

Version

2024.1208.0-lazer

Logs

compressed-logs.zip

[peppy]

I can see how this can happen

osu/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs

Line 485 in cfc38df

previewTrackManager.StopAnyPlaying(this);

But I'm not sure on a fix. We really need this call to be after the screen finishes fading out I guess.

[Joehuu]

This was fixed on overlays in #27898.

Would also need to be done on daily challenge:

osu/osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

Line 472 in 78e9463

previewTrackManager.StopAnyPlaying(this);

[peppy]

The problem is, we don't have an event for a screen being completely suspended, and I'm not sure I'd trust the transform OnComplete here... although I guess that's what was done in the other case so maybe it will work??

[frenzibyte]

Seeing that this issue is happening in more general places, I would be in favour of introducing proper events raised when a screen fully suspends/exits managed explicitly by ScreenStack rather than relying on local transform complete callbacks that may be interrupted by the ScreenStack's own handling of every screen's lifetime.

Either that or more generally wrapping any existing StopAnyPlaying call with this.DelayUntilTransformsFinished so as to not perform while the screen/overlay is still present/interactive.