ctrl+up/down hotkey does not work on the multiplayer and daily challenge screens

[tovc]

Type

Game behaviour

Bug description

doesn't seem like there's any reason that it shouldn't work. I guess assuming DT is disabled as a freemod in multiplayer is correct most of the time? this seems somewhat reasonable, if a bit annoying in multiplayer, but in the daily challenge, DT is always enabled, so it just feels wrong

Screenshots or videos

No response

Version

2024.817.0-lazer

Logs

compressed-logs.zip

[peppy]

Seems valid. This would mean adding ModSpeedHotkeyHandlers to two more screens, at which point I'd hope the key binding handling could be encapsulated within that class.

@bdach What was the reason for not doing this in the first place? On an initial check it looks like the only valid reason would be the pre-check on current screen at song select:

osu/osu.Game/Screens/Select/SongSelect.cs

Line 1024 in b567ab2

if (!this.IsCurrentScreen()) return false;

[bdach]

The primary reason for not doing it was forgetting that multiplayer exists and therefore not caring what was being handled where.

Do note however that adding that in will require carve-outs for checking if rate adjust is even allowable in a given multiplayer context.