Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor fails to parse timestamp links from discussion page #29145

Closed
kadambishreyas opened this issue Jul 27, 2024 · 1 comment · Fixed by #30024
Closed

Editor fails to parse timestamp links from discussion page #29145

kadambishreyas opened this issue Jul 27, 2024 · 1 comment · Fixed by #30024

Comments

@kadambishreyas
Copy link
Contributor

Type

Game behaviour

Bug description

repro:

  1. download this beatmap: https://osu.ppy.sh/beatmapsets/999367#osu/2090130
  2. import the beatmap and open [III.A Nice Derangement of Epitaphs]
  3. navigate to the timestamp link in this comment and click the link

expected behavior:
notice that the ranked version of this beatmap DOES in fact have an object with combo number 11 at 00:38:526.
as such, i expect that the editor would move the timeline to the ms of the timestamp. given that the combo numbers line up, it should also automatically select this object (and all objects in the timestamp).

result:
i receive the notification "Failed to parse editor link".

Screenshots or videos

Screen.Recording.2024-07-27.at.2.07.14.PM.mp4

Version

2024.727.0-lazer

Logs

compressed-logs.zip

@zihadmahiuddin
Copy link

Looks like timestamp on this line is 00:38:526%20(11), it works fine if I replace the %20 with a space so I think just URL-decoding it will fix it but not sure what's the right place to do that, maybe it should be done on all strings received via osu:// URIs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants