Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColourHitErrorMeter resets after a pause #26596

Closed
immorrtalz opened this issue Jan 17, 2024 · 2 comments · Fixed by #26605
Closed

ColourHitErrorMeter resets after a pause #26596

immorrtalz opened this issue Jan 17, 2024 · 2 comments · Fixed by #26605
Assignees
@peppy
Labels
area:gameplay type:behavioural

Comments

@immorrtalz
Copy link

Type

Cosmetic

Bug description

Taiko mode
ColourHitErrorMeter instantly becomes empty right after I press and release the "continue" button in the pause menu
It seems to be just a visual thing

Screenshots or videos

image

Version

2024.114.0-lazer

Logs

compressed-logs.zip
@bdach
Copy link
Collaborator

bdach commented Jan 17, 2024

This is happening because MasterGameplayClockContainer apparently seeks when resuming:

osu/osu.Game/Screens/Play/MasterGameplayClockContainer.cs

Lines 153 to 157 in 6a8a45b

if (LastStopTime != null)
{
Seek(LastStopTime.Value);
LastStopTime = null;
}

which causes the clear.

@peppy
Copy link
Member

peppy commented Jan 17, 2024

I have some in-progress changes which remove that block of code, so stay tuned.

@peppy peppy self-assigned this Jan 18, 2024
@peppy peppy mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:gameplay type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify gameplay pause sequence peppy/osu
3 participants
@peppy @bdach @immorrtalz